Make the fallback dialog less annoying - #3297
Open
infirit wants to merge 6 commits into
Open
Conversation
There is no close button in the window decoration for users to close. And While the escape key may work it's not communicated at all.
I have no idea what this is supposed to do and looks completely unused.
We don't reuse any and we shouldn't so make sure it's gone.
It adds nothing and just makes it hard to see.
Especially in the fallback actions were confusing and bugged. For example add_action was just a stub so the fallback never had an Open button for completed transfers.
infirit
force-pushed
the
fallbackdialogfixes
branch
from
June 10, 2026 16:45
7ccc8fa to
523d2d0
Compare
|
cschramm
reviewed
Jun 11, 2026
| if actions is None: | ||
| actions = [NotificationAction("close", _("_Close"), lambda s: self.close())] | ||
|
|
||
| self.actions[Gtk.ResponseType.DELETE_EVENT] = "close" |
Member
There was a problem hiding this comment.
This is fired by the window manager, e.g., in reaction to Esc or a request to close the window. I think those controls are broken now. Also, actions_cb fired for it (and any other event), and at least BlueAgent.py's on_auth_action relies on that.
| self.add_button(action_name, i) | ||
| i += 1 | ||
| if actions is None: | ||
| actions = [NotificationAction("close", _("_Close"), lambda s: self.close())] |
Member
There was a problem hiding this comment.
self.close() should be redundant here, as do_response already destroys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether we should close automatically is still an open question #3257.