Skip to content

refactor: Remove redundant biometricPolicy parameter from SecureCredentialsManager #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subhankarmaiti merged 2 commits into from
Nov 19, 2025
Merged

refactor: Remove redundant biometricPolicy parameter from SecureCredentialsManager #880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b39f3
refactor: remove biometricPolicy parameter from SecureCredentialsMana…
subhankarmaiti Nov 19, 2025
e8ae146
Merge branch 'main' of https://github.com/auth0/Auth0.Android into re…
subhankarmaiti Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ public class SecureCredentialsManager @VisibleForTesting(otherwise = VisibleForT
private val fragmentActivity: WeakReference<FragmentActivity>? = null,
private val localAuthenticationOptions: LocalAuthenticationOptions? = null,
private val localAuthenticationManagerFactory: LocalAuthenticationManagerFactory? = null,
private val biometricPolicy: BiometricPolicy = BiometricPolicy.Always,
) : BaseCredentialsManager(apiClient, storage, jwtDecoder) {
private val gson: Gson = GsonProvider.gson

Expand Down Expand Up @@ -162,8 +161,7 @@ public class SecureCredentialsManager @VisibleForTesting(otherwise = VisibleForT
auth0.executor,
WeakReference(fragmentActivity),
localAuthenticationOptions,
DefaultLocalAuthenticationManagerFactory(),
localAuthenticationOptions?.policy ?: BiometricPolicy.Always
DefaultLocalAuthenticationManagerFactory()
)

/**
Expand Down Expand Up @@ -1205,8 +1203,9 @@ public class SecureCredentialsManager @VisibleForTesting(otherwise = VisibleForT
internal fun isBiometricSessionValid(): Boolean {
val lastAuth = lastBiometricAuthTime.get()
if (lastAuth == NO_SESSION) return false // No session exists

return when (val policy = biometricPolicy) {

val policy = localAuthenticationOptions?.policy ?: BiometricPolicy.Always
return when (policy) {
is BiometricPolicy.Session,
is BiometricPolicy.AppLifecycle -> {
val timeoutMillis = when (policy) {
Expand Down