Skip to content

refactor: Remove redundant biometricPolicy parameter from SecureCredentialsManager #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
subhankarmaiti merged 2 commits into from
Nov 19, 2025
Merged

refactor: Remove redundant biometricPolicy parameter from SecureCredentialsManager #880

subhankarmaiti merged 2 commits into from
Nov 19, 2025

Conversation

@subhankarmaiti
Copy link
Contributor

@subhankarmaiti subhankarmaiti commented Nov 19, 2025

Removes the redundant biometricPolicy constructor parameter from SecureCredentialsManager. The policy is now accessed directly from localAuthenticationOptions.policy, eliminating duplication and maintaining a single source of truth.

Changes:

  • Removed biometricPolicy parameter from internal constructor
  • Updated isBiometricSessionValid() to access policy from localAuthenticationOptions directly
  • No breaking changes to public API

Testing:

  • All existing tests pass
  • No behavior changes

@subhankarmaiti subhankarmaiti requested a review from a team as a code owner November 19, 2025 07:09
@subhankarmaiti subhankarmaiti merged commit e111c9d into main Nov 19, 2025
7 checks passed
@subhankarmaiti subhankarmaiti deleted the refactor/remove-redundant-policy branch November 19, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmathew92 pmathew92 pmathew92 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@subhankarmaiti @pmathew92