Skip to content

fix: move TypedDict replacement from Python 3.13 to 3.15 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baluyotraf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: move TypedDict replacement from Python 3.13 to 3.15 #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29682eb
fix: move TypedDict from Python 3.13 to 3.15
baluyotraf Jul 17, 2026
963a9ff
fix: regenerate the main script after the typing replacement change
baluyotraf Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion reorder_python_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,6 @@ def _fix_file(
'typing_extensions=typing:TypeIs',
'typing_extensions=typing:TypeVar',
'typing_extensions=typing:TypeVarTuple',
'typing_extensions=typing:TypedDict',
'typing_extensions=typing:get_protocol_members',
'typing_extensions=typing:is_protocol',
'typing_extensions=typing:runtime_checkable',
Expand All @@ -565,8 +564,12 @@ def _fix_file(
REPLACES[(3, 14)].update((
'typing_extensions=typing:evaluate_forward_ref',
))
REPLACES[(3, 15)].update((
'typing_extensions=typing:TypedDict',
))
# END GENERATED


# GENERATED VIA generate-typing-pep585-rewrites
REPLACES[(3, 9)].update((
'typing=collections.abc:AsyncGenerator',
Expand Down
6 changes: 5 additions & 1 deletion testing/generate-typing-rewrite-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ import typing_extensions
# the first one on py313+, and (Async)ContextManager now has an optional
# second parameter with a default value; typing_extensions backports these
# changes.
# - Python 3.15 adds the PEP-728 which allows closed and extra_items to be
# passed to TypedDict. Importing TypedDict via typing_extensions is now a
# valid case before 3.15.
CUSTOM_TYPING_EXT_SYMBOLS = {
(3, 9): {'get_type_hints'},
(3, 10): {'get_origin', 'get_args', 'Literal', 'NewType'},
Expand All @@ -53,9 +56,10 @@ CUSTOM_TYPING_EXT_SYMBOLS = {
},
(3, 13): {
'AsyncContextManager', 'ContextManager', 'AsyncGenerator', 'Generator',
'TypeVar', 'TypeVarTuple', 'ParamSpec', 'TypedDict', 'Protocol',
'TypeVar', 'TypeVarTuple', 'ParamSpec', 'Protocol',
'runtime_checkable',
},
(3, 15): {'TypedDict'},
}


Expand Down
Loading