fix: move TypedDict replacement from Python 3.13 to 3.15 - #445
Open
baluyotraf wants to merge 2 commits into
Open
fix: move TypedDict replacement from Python 3.13 to 3.15#445baluyotraf wants to merge 2 commits into
baluyotraf wants to merge 2 commits into
Conversation
Owner
|
and what happens when you regenerate it |
Owner
|
and now look at what it generated |
Author
|
Not sure if adding a special case is the right way to go right now. I think down the line it probably becomes part of |
Owner
|
no but isn't that mapping exactly the entire point? |
baluyotraf
force-pushed
the
fix/remove-typeddict-p313
branch
from
July 17, 2026 23:44
27918a7 to
963a9ff
Compare
Author
|
fair enough. got used to people downstream doing black magic so I was a bit reserved in making the change. Thanks for the reviews. |
baluyotraf
changed the title
Owner
|
looks good -- I'm going to batch this with 3.15 changes when rc1 drops |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay give me one more chance. This looks to be the right place given the comments.