Skip to content

check: skip listAppPasswords when the PDS rejects OAuth sessions #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zzstoatzz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

check: skip listAppPasswords when the PDS rejects OAuth sessions #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/check/src/checks/account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,16 @@ const listAppPasswords: Check = {
const client = authedClient(ctx.agent!);
const res = await client.get("com.atproto.server.listAppPasswords", {});
if (!res.ok) {
// The reference PDS forbids OAuth credentials on this endpoint
// ("OAuth credentials are not supported for this endpoint"), so a
// 403 from our DPoP session is conformant behavior, not a failure.
if (res.status === 403) {
return {
status: "skip",
message: "endpoint rejects OAuth sessions (matches reference PDS)",
evidence: { response: { status: res.status, body: res.data } },
};
}
return {
status: "fail",
message: `${res.data.error}: ${res.data.message ?? ""}`.trim(),
Expand Down