check: skip listAppPasswords when the PDS rejects OAuth sessions - #237
Draft
zzstoatzz wants to merge 1 commit into
Draft
check: skip listAppPasswords when the PDS rejects OAuth sessions#237zzstoatzz wants to merge 1 commit into
zzstoatzz wants to merge 1 commit into
Conversation
the reference PDS explicitly forbids OAuth credentials on
com.atproto.server.listAppPasswords ('OAuth credentials are not
supported for this endpoint'), so a 403 from the checker's DPoP
session is conformant behavior. treat it as a skip instead of a
failure.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WEGRiZrVy9BCS4sXh2BKbg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
listAppPasswordscheck runs against an OAuth (DPoP) session, but the reference PDS explicitly forbids OAuth credentials on this endpoint — its handler throwsForbiddenError('OAuth credentials are not supported for this endpoint')for any OAuth credential (listAppPasswords.ts). so a 403 here is conformant behavior, and a PDS matching the reference currently fails the check. treat that 403 as a skip instead.seen in the wild against a zds instance, which gates app-password management behind password sessions the same way and returned
AuthFactorTokenRequired: Password session required:opened as a draft since you may prefer to key the skip off the error body rather than the bare status, or to surface it as a pass with a note.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WEGRiZrVy9BCS4sXh2BKbg