Skip to content

NIFI-15779 Allow error message to appear on controller service ui when service is enabling but not valid #11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NissimShiman wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

NIFI-15779 Allow error message to appear on controller service ui when service is enabling but not valid #11182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...nents/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,7 @@ public void run() {
final ConfigurationContext configContext = providedConfigurationContext == null
? new StandardConfigurationContext(serviceNode, controllerServiceProvider, null)
: providedConfigurationContext;
final ControllerService controllerService = getControllerServiceImplementation();

if (!isActive()) {
LOG.warn("Enabling {} stopped: no active status", serviceNode);
Expand All @@ -690,7 +691,15 @@ public void run() {
} else {
final Collection<ValidationResult> errors = validationState.getValidationErrors();
if (completeExceptionallyOnFailure) {
future.completeExceptionally(new IllegalStateException("Enabling %s failed: Validation Status [%s] Errors %s".formatted(serviceNode, validationStatus, errors)));
String message = "Enabling %s failed: Validation Status [%s] Errors %s".formatted(serviceNode, validationStatus, errors);
future.completeExceptionally(new IllegalStateException(message));
// Controlling frequency of error messages.
// Initial messages will be at 0 seconds, 10 seconds, 36 seconds, 78 seconds etc.
long delay = validationDelay.get();
if (delay % 4000 == 0 || delay >= 75000) {
final ComponentLog componentLog = new SimpleProcessLogger(getIdentifier(), controllerService, new StandardLoggingContext(serviceNode));
componentLog.error("Failed to invoke @OnEnabled method. {}", message);
}
}

final long selectedValidationDelay = getDelay(validationDelay, INCREMENTAL_VALIDATION_DELAY_MS);
Expand All @@ -712,7 +721,6 @@ public void run() {
return;
}

final ControllerService controllerService = getControllerServiceImplementation();
try {
try (final NarCloseable ignored = NarCloseable.withComponentNarLoader(getExtensionManager(), controllerService.getClass(), getIdentifier())) {
ReflectionUtils.invokeMethodsWithAnnotation(OnEnabled.class, controllerService, configContext);
Expand Down
Loading