NIFI-15779 Allow error message to appear on controller service ui when service is enabling but not valid#11182
Open
NissimShiman wants to merge 1 commit intoapache:mainfrom
Open
NIFI-15779 Allow error message to appear on controller service ui when service is enabling but not valid#11182NissimShiman wants to merge 1 commit intoapache:mainfrom
NissimShiman wants to merge 1 commit intoapache:mainfrom
Conversation
…n service is enabling but not valid
exceptionfactory
requested changes
May 6, 2026
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this change @NissimShiman. This introduces some arbitrary delay numbers, and although the comments are helpful, this appears to revert back to some previous behavior. In addition, the change to declare the message before completeExceptionally() does not appear to be needed.
Rather than introducing this approach, it seems like some other strategy could provide a better way of surfacing enabling failures.
Contributor
Author
|
Thank you @exceptionfactory for looking at this. Could converting LOG.warn() to componentLog.warn() be a better approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15779
Besides the specific case in the jira, this is useful for cases where a controller service is ghosted or is using an invalid property value (as a result of a migration) and the service is trying to enable but is invalid.
There is now an error icon next to the controller service.
Logic was added to keep the logging manageable, as the framework retries to enable the service.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation