Skip to content

[fix](regression) Preserve flexible-update fixtures across upgrade stages #69555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Oct 25, 2026
Merged

[fix](regression) Preserve flexible-update fixtures across upgrade stages #69555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions regression-test/suites/unique_with_mow_p0/flexible/downgrade/test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,25 @@ suite('test_flexible_partial_update_downgrade', 'p0,restart_fe') {
for (def use_row_store : [false, true]) {
logger.info("current params: use_row_store: ${use_row_store}")
def tableName = "test_f_downgrade_${use_row_store}"
if (context.config.withOutLoadData) {
// The initial run leaves this final fixture for every rolling-upgrade stage.
// Check it before any writes, without recreating the table or replaying the load.
check_sqls_result_equal(
"select k,v1,v2,v3,v4,v5 from ${tableName} order by k",
"""select 0 as k, 0 as v1, 0 as v2, 0 as v3, 0 as v4, 0 as v5
union all select 1, 999, 111, 999, 1, 999
union all select 2, 888, 20, 888, 222, 888
union all select 3, 10, 10, 10, 10, 10
union all select 4, 12, 12, 12, 12, 12
union all select 7, 7, 7, 7, 7, 7
union all select 8, 8, 8, 8, 8, 8
union all select 9, 9, 9, 9, 9, 9
union all select 20, 555, 9876, 555, 1234, 555
union all select 30, 11, 11, 11, 11, 11 order by k""")
def persistedSchema = sql "show create table ${tableName}"
assertTrue(persistedSchema.toString().contains('"enable_unique_key_skip_bitmap_column" = "true"'))
continue
}
qt_sql "select k,v1,v2,v3,v4,v5 from ${tableName} order by k;"

sql "set enable_unique_key_partial_update=true;"
Expand Down
19 changes: 19 additions & 0 deletions regression-test/suites/unique_with_mow_p0/flexible/upgrade/test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,25 @@ suite('test_flexible_partial_update_upgrade', 'p0,restart_fe') {
for (def use_row_store : [false, true]) {
logger.info("current params: use_row_store: ${use_row_store}")
def tableName = "test_f_upgrade_${use_row_store}"
if (context.config.withOutLoadData) {
// The initial run leaves this final fixture for every rolling-upgrade stage.
// Check it before any writes, without recreating the table or replaying the load.
check_sqls_result_equal(
"select k,v1,v2,v3,v4,v5 from ${tableName} order by k",
"""select 0 as k, 0 as v1, 0 as v2, 0 as v3, 0 as v4, 0 as v5
union all select 1, 999, 111, 999, 1, 999
union all select 2, 888, 20, 888, 222, 888
union all select 3, 10, 10, 10, 10, 10
union all select 4, 12, 12, 12, 12, 12
union all select 7, 7, 7, 7, 7, 7
union all select 8, 8, 8, 8, 8, 8
union all select 9, 9, 9, 9, 9, 9
union all select 20, 555, 9876, 555, 1234, 555
union all select 30, 11, 11, 11, 11, 11 order by k""")
def persistedSchema = sql "show create table ${tableName}"
assertTrue(persistedSchema.toString().contains('"enable_unique_key_skip_bitmap_column" = "true"'))
continue
}
sql """alter table ${tableName} enable feature "UPDATE_FLEXIBLE_COLUMNS"; """
def show_res = sql "show create table ${tableName}"
assertTrue(show_res.toString().contains('"enable_unique_key_skip_bitmap_column" = "true"'))
Expand Down
Loading