Repository navigation
[fix](regression) Preserve flexible-update fixtures across upgrade stages - #69555
Merged
yiguolei merged 1 commit intoOct 25, 2026
Merged
Conversation
…ages ### What problem does this PR solve? The rolling-upgrade regression runs these suites once during initialization and again with `-w` after each upgrade stage. Initialization updates and deletes rows in the fixtures and enables `UPDATE_FLEXIBLE_COLUMNS`. Repeating the original test then compares the final data against the initial snapshot, or attempts to enable an already-enabled feature, before checking compatibility. Keep the original initialization path unchanged. During `-w` verification, compare the complete ordered persisted fixture against fixed reference SQL and verify the flexible-update table property for both row-store variants. This path performs no writes, table recreation, or reload, so corrupted, missing, and additional persisted rows remain failures. Existing generated output files remain unchanged. Scope: subsequent upgrade stages verify persisted-data and feature-metadata compatibility. They no longer replay this suite's initialization DML; this change does not establish mixed-version write coverage or binary downgrade support. ### Release note None ### Check List (For Author) - Test: `git diff --check`; isolated Groovy syntax/suite-registration and control-flow harness, covering unchanged initialization call traces, both row-store tables, three repeated read-only verification runs, and rejection of corrupted/missing/additional rows and a disabled feature property. This is not a Doris cluster runtime test; rolling-upgrade validation remains pending with case artifacts containing this fix. - Behavior changed: Yes, `-w` checks the persisted final fixture instead of replaying initialization operations. - Does this need documentation: No
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
yiguolei
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The rolling-upgrade regression runs these suites once during initialization and again with
-wafter each upgrade stage. Initialization updates and deletes rows in the fixtures and enablesUPDATE_FLEXIBLE_COLUMNS. Repeating the original test then compares the final data against the initial snapshot, or attempts to enable an already-enabled feature, before checking compatibility.Keep the original initialization path unchanged. During
-wverification, compare the complete ordered persisted fixture against fixed reference SQL and verify the flexible-update table property for both row-store variants. This path performs no writes, table recreation, or reload, so corrupted, missing, and additional persisted rows remain failures. Existing generated output files remain unchanged.Scope: subsequent upgrade stages verify persisted-data and feature-metadata compatibility. They no longer replay this suite's initialization DML; this change does not establish mixed-version write coverage or binary downgrade support.
Release note
None
Check List (For Author)
git diff --check; isolated Groovy syntax/suite-registration and control-flow harness, covering unchanged initialization call traces, both row-store tables, three repeated read-only verification runs, and rejection of corrupted/missing/additional rows and a disabled feature property. This is not a Doris cluster runtime test; rolling-upgrade validation remains pending with case artifacts containing this fix.-wchecks the persisted final fixture instead of replaying initialization operations.