fix(app): fix upload child folder of repo bug#16684
Open
natewill wants to merge 6 commits intoanomalyco:devfrom
Open
fix(app): fix upload child folder of repo bug#16684natewill wants to merge 6 commits intoanomalyco:devfrom
natewill wants to merge 6 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
added
needs:issue
needs:compliance
6 tasks
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
natewill
changed the title
6 tasks
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Member
|
hey @natewill i'm not seeing the videos, they don't seem to load |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16645 and
Closes #16713
Type of change
What does this PR do?
Issue #16645 shows uploading a child folder of a git repo that is in the side bar duplicates the project, while issue #16713 shows uploading child folders of a git repo not in the sidebar break the UI
This PR resolves all uploaded directory paths within a git repo to said repo's root, even if the repo hasn't been opened before child folder upload.
The backend already resolves project paths the same way but the frontend root resolution wasn't working properly so I fixed it.
How did you verify your code works?
Tested on desktop app and web app, including testing by uploading multiple worktrees at once, symlinked worktrees, deeplinks, etc. while also running local tests that all passed
Screenshots / recordings
Before and After Fix:
https://youtu.be/SUX5ZuyzvvQ
Checklist