fix(app): fix worktree upload workspaces bug#16683
Open
natewill wants to merge 6 commits intoanomalyco:devfrom
Open
fix(app): fix worktree upload workspaces bug#16683natewill wants to merge 6 commits intoanomalyco:devfrom
natewill wants to merge 6 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
7ee3157 to
35b2c39
Compare
6 tasks
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Member
|
hey @natewill i'm not seeing the videos, they don't seem to load |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16474
Type of change
What does this PR do?
Issue #16474 shows uploading a git worktree via "Open Project" when workspaces are disabled results in the main git worktree being displayed the UI instead of the uploaded git worktree. Projects by default have workspaces disabled.
This PR auto-enables the project's workspaces when the uploaded directory matches a git worktree, so the selected worktree is not hidden.
How did you verify your code works?
Tested on desktop app and web app, including testing by uploading multiple worktrees at once, symlinked worktrees, deeplinks, etc. while also running local tests that all passed
Screenshots / recordings
https://youtu.be/uDb5Sys8SJ8
Checklist