🛡️ Sentinel: [security improvement] Prevent Terminal Injection and DoS

project/app.py

@@ -1,4 +1,4 @@
-from click import command, option, secho, version_option
+from click import UsageError, command, option, secho, version_option
 
 
 @command(
@@ -22,6 +22,11 @@ def main(name: str = "World"):
     Args:
       name: the name to be greeted
     """
+    if len(name) > 100:
+        raise UsageError("Invalid name: maximum length is 100 characters.")
+    if any(c < " " for c in name):
+        raise UsageError("Invalid name: control characters are not allowed.")
+
     secho(f"Hello {name}! 👋", fg="green", bold=True)
 
 

tests/test_app.py

@@ -16,3 +16,17 @@ def test_greet():
     result = runner.invoke(main, ["--name", "Jules"])
     assert result.exit_code == 0
     assert "Hello Jules! 👋" in result.output
+
+
+def test_name_too_long():
+    runner = CliRunner()
+    result = runner.invoke(main, ["--name", "A" * 101])
+    assert result.exit_code != 0
+    assert "maximum length is 100 characters" in result.output
+
+
+def test_name_control_characters():
+    runner = CliRunner()
+    result = runner.invoke(main, ["--name", "Injected\x1b[31mRed\x1b[0m"])
+    assert result.exit_code != 0
+    assert "control characters are not allowed" in result.output