π‘οΈ Sentinel: [security improvement] Prevent Terminal Injection and DoS#96
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: CLI input (
--name) was echoed back to the terminal without validation.π― Impact: Attackers could provide ANSI escape sequences to manipulate the terminal or very long strings to cause resource exhaustion in logs/terminals.
π§ Fix: Added validation to
project/app.pyto limit name length to 100 characters and block control characters (ASCII < 32).β Verification: Added unit tests in
tests/test_app.pycovering both length and control character constraints. Verified withpytest.PR created automatically by Jules for task 11232632176669271376 started by @amrabed