Skip to content

Make anyone happy about warnings and margin in filtering.#4384

Merged
alejoe91 merged 4 commits intoSpikeInterface:mainfrom
samuelgarcia:margin_warning
Feb 11, 2026
Merged

Make anyone happy about warnings and margin in filtering.#4384
alejoe91 merged 4 commits intoSpikeInterface:mainfrom
samuelgarcia:margin_warning

Conversation

@samuelgarcia
Copy link
Member

@samuelgarcia samuelgarcia commented Feb 11, 2026

Make anyone happy about warnings and margin in filtering:

  • avoid unnecessary wrning when not needed
  • do not warn when loading old spikeinterface files
  • warn and raise for new case
  • do warn but not raise when loading old spikeinterface files in LFP cases.

@alejoe91 @yger @chrishalcrow

this will close #4334

@alejoe91 alejoe91 added preprocessing Related to preprocessing module deprecations Related to code deprecation labels Feb 11, 2026
@alejoe91 alejoe91 added this to the 0.104.0 milestone Feb 11, 2026
@alejoe91 alejoe91 merged commit 5db73d6 into SpikeInterface:main Feb 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecations Related to code deprecation preprocessing Related to preprocessing module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants