Fix micro version check in base#4388
Closed
alejoe91 wants to merge 7 commits intoSpikeInterface:mainfrom
Closed
Conversation
Member
|
Looks good, but can you explain why we need to do this now? |
Member
Author
If we don't we will have the margin init error until we release 0.104.0, which honestly is ok. I wanted to test the mechanism though, and with this PR the warnign goes away. |
Member
Author
|
So let's not merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #4384, we also have to check the micro version to handlo backward compatible load, not only major and minot (which is default)