Skip to content

Fix bug when reading domain IDs from .vtus #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktbolt merged 5 commits into from
Mar 30, 2026
Merged

Fix bug when reading domain IDs from .vtus #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60078cc
fixing bug in VtkData.cpp
javijv4 Mar 26, 2026
edb0bb1
adding fsi test
javijv4 Mar 26, 2026
ea2dd90
adding fsi test
javijv4 Mar 26, 2026
a9b263c
updating ep test
javijv4 Mar 27, 2026
17e1d13
removing pipe_domains test and running both slab_domain tests
javijv4 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Code/Source/solver/VtkData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ Array<double> VtkVtpData::get_points() const

bool VtkVtpData::has_cell_data(const std::string& data_name)
{
int num_arrays = impl->vtk_polydata->GetPointData()->GetNumberOfArrays();
int num_arrays = impl->vtk_polydata->GetCellData()->GetNumberOfArrays();

for (int i = 0; i < num_arrays; i++) {
if (!strcmp(impl->vtk_polydata->GetCellData()->GetArrayName(i), data_name.c_str())) {
Expand Down Expand Up @@ -1059,7 +1059,7 @@ void VtkVtuData::copy_points(Array<double>& points)

bool VtkVtuData::has_cell_data(const std::string& data_name)
{
int num_arrays = impl->vtk_ugrid->GetPointData()->GetNumberOfArrays();
int num_arrays = impl->vtk_ugrid->GetCellData()->GetNumberOfArrays();

for (int i = 0; i < num_arrays; i++) {
if (!strcmp(impl->vtk_ugrid->GetCellData()->GetArrayName(i), data_name.c_str())) {
Expand Down
4 changes: 3 additions & 1 deletion tests/cases/cep/slab_domains/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@

# **Problem Description**

Simulate the propagation of a planar wave in a slab with different domain conductances using the ten-Tusscher-Panfilov cell activation model.
Simulate the propagation of a planar wave in a slab with different domain conductances using the ten-Tusscher-Panfilov cell activation model. The domains are specified in the `mesh/domainIDs.vtu` file.

![Slab domains visualization](domains.png)

For reference, the domains are also specified in the `mesh/domainIDs.dat` and the inpute file `solver_dat.xml` can be used to run the test using the `.dat` domain file. Both approaches are equivalent.

## References
K. H. W. J. ten Tusscher, D. Noble, P. J. Noble, and A. V. Panfilov. A model for human ventricular tissue. American Journal of Physiology-Heart and Circulatory Physiology,
286(4):H1573–H1589, apr 2004.
Expand Down
Loading
Loading