Skip to content

Fix bug when reading domain IDs from .vtus#521

Merged
ktbolt merged 5 commits intoSimVascular:mainfrom
javijv4:dev_520_readcell
Mar 30, 2026
Merged

Fix bug when reading domain IDs from .vtus#521
ktbolt merged 5 commits intoSimVascular:mainfrom
javijv4:dev_520_readcell

Conversation

@javijv4
Copy link
Copy Markdown
Contributor

@javijv4 javijv4 commented Mar 27, 2026

Current situation

Resolves #520

Release Notes

  • Fixed bug
  • Added an FSI and an CEP test that checks the functionality to read domain IDs from a .vtu file.

Testing

New tests are:

  • tests/cases/fsi/pipe_3d_domains
  • tests/cases/cep/slab_domains

Code of Conduct & Contributing Guidelines

@javijv4 javijv4 changed the title Dev 520 readcell Fix bug when reading domain IDs from .vtus Mar 27, 2026
@javijv4 javijv4 requested review from kko27, ktbolt and msbazzi March 27, 2026 00:49
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.84%. Comparing base (fbf70b4) to head (17e1d13).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Code/Source/solver/VtkData.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   67.79%   67.84%   +0.05%     
==========================================
  Files         168      168              
  Lines       32798    32797       -1     
  Branches     5767     5768       +1     
==========================================
+ Hits        22234    22252      +18     
+ Misses      10426    10408      -18     
+ Partials      138      137       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@ktbolt
Copy link
Copy Markdown
Collaborator

ktbolt commented Mar 27, 2026

@javijv4 Testing reading domain IDs from a file should really be a unit test; does not make sense to have two pipe_3d tests that differ only by how they read domain IDs.

Adding a unit test is probably too much to do for this right now so just remove the pipe_3d_domains test.

@ktbolt
Copy link
Copy Markdown
Collaborator

ktbolt commented Mar 27, 2026

@javijv4 There are two solver XML files in svMultiPhysics/tests/cases/cep/slab_domains. Can we run both of them ?

@javijv4
Copy link
Copy Markdown
Contributor Author

javijv4 commented Mar 27, 2026

@ktbolt, yep. I removed the pipe test and updated the cep slab_domains test to run both .xml.

Copy link
Copy Markdown
Contributor

@kko27 kko27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ktbolt ktbolt merged commit 8774039 into SimVascular:main Mar 30, 2026
8 checks passed
@javijv4 javijv4 deleted the dev_520_readcell branch March 30, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VtkData has_cell_data function uses wrong function to get the number of arrays

3 participants