remove legacy parser from patternTranslate #790
Draft
+59
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jesse-shopify
force-pushed
the
rm-legacy-parser
branch
from
f6ebf10 to
a9017ea
Compare
jesse-shopify
force-pushed
the
remove-legacy-parser-pattern-translate
branch
from
b681381 to
f13541d
Compare
jesse-shopify
force-pushed
the
remove-legacy-parser-pattern-translate
branch
from
f13541d to
1741f1e
Compare
jesse-shopify
force-pushed
the
rm-legacy-parser
branch
from
a9017ea to
032bdf2
Compare
jesse-shopify
changed the base branch from
rm-legacy-parser
to
graphite-base/790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.