Remove legacy parse tree construction from the Prism translator #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
amomchilov
force-pushed
the
rm-legacy-parser
branch
3 times, most recently
from
c72811b to
42c2139
Compare
jesse-shopify
force-pushed
the
rm-legacy-parser
branch
from
42c2139 to
882e407
Compare
amomchilov
force-pushed
the
rm-legacy-parser
branch
from
882e407 to
f355ce0
Compare
amomchilov
changed the title
computeSendLoc() helper
This was referenced Dec 4, 2025
jesse-shopify
force-pushed
the
rm-legacy-parser
branch
from
f355ce0 to
34d2f61
Compare
Co-authored-by: Jesse Johnson <[email protected]>
jesse-shopify
force-pushed
the
rm-legacy-parser
branch
from
f6ebf10 to
a9017ea
Compare
Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
…onPtr names updates to desugarRegexp and desugarRegexpOptions
These are cases where we know the resuling desugar trees will differ, but we're happy with the differences. For example, in some cases, Prism can throw away less of tree for invalid Ruby code. Previously, we were doing the comparison in the `verify_prism_regression_tests.sh` script, but now we're doing it as part of the test suite. As such, a magic comment seemed like the best way to go.
jesse-shopify
force-pushed
the
rm-legacy-parser
branch
from
a9017ea to
032bdf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.