Skip to content

Fix compatibility with soon to be released jupyternaut 0.1.x #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brichet merged 2 commits into from
Sep 2, 2026
Merged

Fix compatibility with soon to be released jupyternaut 0.1.x #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a1afd1
Look for custom models
cmarmo Aug 18, 2026
0aab639
Take initial_language_model into account if set
cmarmo Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions jupyter_ai_tutor/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,24 @@ async def post(self):
raise tornado.web.HTTPError(
503, "Jupyternaut config manager is not available"
)
if not config_manager.chat_model:
raise tornado.web.HTTPError(
503,
"No chat model is configured. Set one in 'Settings > AI Settings'.",
)
model_used_string = f"/* MODEL USED: {config_manager.chat_model} (ACTION: {action}) */\n\n"
chat_model = config_manager.chat_model
chat_model_params = config_manager.chat_model_args
if not chat_model:
if config_manager.model_provider_id is not None:
# If `initial_language_model` is set take the corresponding custom model

@brichet brichet Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess initial_language_model is model_provider_id ?

@cmarmo cmarmo Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if I understand correctly
https://github.com/jupyter-ai-contrib/jupyter-ai-jupyternaut/blob/04a485ef5dac3c7ac67337f3784ce6c95d7f67a1/jupyter_ai_jupyternaut/extension_app.py#L171-L173

selected = config_manager.model_provider_id
chat_model = config_manager.get_custom_model(selected)
chat_model_params = config_manager.get_custom_model(selected).params
else:
# If `initial_language_model` is not set take the first custom model
chat_model = config_manager.custom_models[0].model_id
chat_model_params = config_manager.custom_models[0].params
if not chat_model:
raise tornado.web.HTTPError(
503,
"No chat model is configured. Set one in 'Settings > Jupyternaut settings'.",
)
model_used_string = f"/* MODEL USED: {chat_model} (ACTION: {action}) */\n\n"

self.set_header("Content-Type", "text/event-stream")
self.set_header("Cache-Control", "no-cache")
Expand Down Expand Up @@ -80,8 +92,8 @@ async def post(self):
from langchain_core.messages import HumanMessage, SystemMessage

model = ChatLiteLLM(
**config_manager.chat_model_args,
model=config_manager.chat_model,
**chat_model_params,
model=chat_model,
streaming=True,
)

Expand Down
Loading