Fix compatibility with soon to be released jupyternaut 0.1.x - #38
Open
cmarmo wants to merge 1 commit into
Open
Conversation
Member
|
For the record, the change about config is in jupyter-ai-contrib/jupyter-ai-jupyternaut#70, and has been released in 0.1.0b0 |
brichet
reviewed
Aug 19, 2026
brichet
left a comment
Member
There was a problem hiding this comment.
Thanks @cmarmo for this PR.
This change seems compatible with both <0.1 and 0.1.x 👍
It looks good to me, but it may worth adding a note about this workaround. A proper solution in the long run would be to get these settings from JupyternautPersona itself I think, or to be able to set a default model.
Contributor
Author
|
Thanks @brichet for your review! Do you mind if I take one or two days more to understand how and if the default is set in JupyterNaut? Otherwise I will add a comment: Indeed, I don't find the current solution satisfying... 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
the soon to be released version of jupyternaut changes the way custom models are configured.
This pull request adds compatibility with the new configuration schema.
It fixes #37
Thank you for considering it.
NB: I couldn't find a way to retrieve the default model set in JupyterNaut as the server side configuration, eg
doesn't seem to have any effect on my installation.
For now I am using the first custom model of the list.
I need to investigate more on the JupyterNaut side.