Skip to content

fix(cmake): report the real protobuf failure instead of a download error #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philomath213 merged 1 commit into from
Sep 5, 2026
+16 −5
Merged

fix(cmake): report the real protobuf failure instead of a download error #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions cmake/protobuf.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,22 @@ FetchContent_MakeAvailable(protocolbuffers_protobuf)
set(Protobuf_ROOT ${protocolbuffers_protobuf_SOURCE_DIR}/cmake)
set(Protobuf_DIR ${Protobuf_ROOT}/${CMAKE_INSTALL_LIBDIR}/cmake/protobuf)

message(STATUS "Setting up protobuf ...")
message(STATUS "Configuring protobuf ...")
execute_process(
COMMAND
${CMAKE_COMMAND} -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -D protobuf_BUILD_TESTS=OFF -D protobuf_BUILD_PROTOC_BINARIES=ON -D CMAKE_POSITION_INDEPENDENT_CODE=ON -G "${CMAKE_GENERATOR}" .
RESULT_VARIABLE result
WORKING_DIRECTORY ${Protobuf_ROOT})
if(result)
message(FATAL_ERROR "Failed to download protobuf (${result})!")
# Nothing is downloaded here - FetchContent already retrieved the sources
# above. This step configures them, so the cause is in the nested CMake
# output printed just before this message.
message(
FATAL_ERROR
"Failed to configure protobuf in ${Protobuf_ROOT} (exit ${result}). "
"See the CMake output above for the underlying error. If it reports "
"'Compatibility with CMake < 3.5 has been removed', re-run the build "
"with CMAKE_POLICY_VERSION_MINIMUM=3.5 set in your environment.")
endif()

message(STATUS "Building protobuf ...")
Expand All @@ -29,7 +37,7 @@ execute_process(
RESULT_VARIABLE result
WORKING_DIRECTORY ${Protobuf_ROOT})
if(result)
message(FATAL_ERROR "Failed to build protobuf (${result})!")
message(FATAL_ERROR "Failed to build protobuf in ${Protobuf_ROOT} (exit ${result})")
endif()

message(STATUS "Installing protobuf ...")
Expand All @@ -39,7 +47,7 @@ if(WIN32)
RESULT_VARIABLE result
WORKING_DIRECTORY ${Protobuf_ROOT})
if(result)
message(FATAL_ERROR "Failed to build protobuf (${result})!")
message(FATAL_ERROR "Failed to install protobuf in ${Protobuf_ROOT} (exit ${result})")
endif()
endif()

Expand Down Expand Up @@ -76,7 +84,10 @@ execute_process(
RESULT_VARIABLE result
WORKING_DIRECTORY ${Protobuf_ROOT})
if(result)
message(FATAL_ERROR "Failed to install protobuf (${result})!")
message(
FATAL_ERROR
"Failed to generate C++ sources from the .proto files in ${PROTO_ROOT} "
"using ${Protobuf_PROTOC_EXECUTABLE} (exit ${result})")
endif()

include_directories(${PROTO_ROOT})
Expand Down
Loading