fix(cmake): report the real protobuf failure instead of a download error - #527
Merged
Conversation
youben11
approved these changes
Sep 2, 2026
philomath213
force-pushed
the
fix/protobuf-error-messages
branch
from
September 5, 2026 16:08
ed3c22e to
80900a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #526 reports that a source build on Alpine fails with Failed to download protobuf. The message is wrong. The build downloads nothing at that step. FetchContent already fetched the sources. The step that fails configures them.
The configure message now points to the nested CMake output. It also names the
CMAKE_POLICY_VERSION_MINIMUM=3.5workaround. This is the usual cause. Vendored protobuf 3.15.8 declares a pre-3.5 minimum, and CMake 4.x rejects it.I tested both cases on python:alpine with CMake 4.2.3. Without the workaround, the new message reports the correct cause. With the workaround, the build completes and HE arithmetic gives correct results.