Add build context usage comment to urc/Dockerfile#882
Merged
mskrzypkows merged 2 commits intourc-cli-dockerfilefrom Feb 27, 2026
Merged
Add build context usage comment to urc/Dockerfile#882mskrzypkows merged 2 commits intourc-cli-dockerfilefrom
mskrzypkows merged 2 commits intourc-cli-dockerfilefrom
Conversation
Merged
…repo root Co-authored-by: mskrzypkows <10705549+mskrzypkows@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update URC CLI Dockerfile based on PR feedback
Add build context usage comment to urc/Dockerfile
Feb 27, 2026
mskrzypkows
approved these changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit build-context guidance to urc/Dockerfile so users build from the repository root (required due to references to root rust-toolchain.toml and workspace Cargo.toml), preventing broken builds when using docker build urc/.
Changes:
- Add a top-of-file comment stating the Docker build context must be the repo root.
- Provide the correct
docker build -f urc/Dockerfile .invocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mskrzypkows
added a commit
that referenced
this pull request
Mar 4, 2026
* Dockerfile for URC CLI, better error logs * fmt * Update urc/Dockerfile Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add build context usage comment to urc/Dockerfile (#882) * Initial plan * Add usage comment to urc/Dockerfile clarifying build context must be repo root Co-authored-by: mskrzypkows <10705549+mskrzypkows@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mskrzypkows <10705549+mskrzypkows@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: mskrzypkows <10705549+mskrzypkows@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What's this PR do?
Addresses feedback from #881: adds a comment at the top of
urc/Dockerfiledocumenting that the build context must be the repository root, noturc/. Without this, users runningdocker build urc/will get a broken build since the Dockerfile referencesrust-toolchain.tomland the workspaceCargo.tomlat the repo root.📎 Related issues (optional)
🧠 Context
The Dockerfile copies
rust-toolchain.tomlfrom the repo root and builds viacargo build -p urc, which requires the workspace-levelCargo.toml. Usingurc/as the build context silently fails. The comment makes the required invocation explicit without adding any tooling overhead.✅ Checklist
feature/<name>🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.