Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a container build for the urc-cli binary and improves CLI error handling by moving fallible logic into a run() function and providing clearer argument-parse errors for the opt-in-to-slasher command.
Changes:
- Add
urc/Dockerfileto build and runurc-cliin a minimal distroless image. - Refactor CLI entrypoint to print errors and exit non-zero on failure.
- Improve validation/error messages for private key, RPC URL, registry address, and command parameters in
opt_in_to_slasher.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
urc/src/cli/main.rs |
Refactors main into main + run() and adds more user-friendly parsing errors for opt_in_to_slasher inputs. |
urc/Dockerfile |
Introduces a multi-stage Docker build producing a distroless runtime image containing only urc-cli and CA certificates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@mskrzypkows I've opened a new pull request, #882, to work on those changes. Once the pull request is ready, I'll request review from you. |
4 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Add usage comment to urc/Dockerfile clarifying build context must be repo root Co-authored-by: mskrzypkows <10705549+mskrzypkows@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mskrzypkows <10705549+mskrzypkows@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.