Skip to content

WebView (Windows): use ICoreWebView2ControllerOptions4 for AllowHostInputProcessing #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakepenn merged 1 commit into from
May 23, 2026
Merged

WebView (Windows): use ICoreWebView2ControllerOptions4 for AllowHostInputProcessing #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/juce_gui_extra/native/juce_WebBrowserComponent_windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,7 @@ class WebBrowserComponent::Impl::Platform::WebView2 final : public WebBrowserCom
// has reported editable DOM focus we set put_Handled(TRUE) so the
// WebView keeps the key for in-DOM editing (e.g. Tab to indent,
// Esc to dismiss a popover). This complements
// ICoreWebView2ControllerOptions2::AllowHostInputProcessing, which
// ICoreWebView2ControllerOptions4::AllowHostInputProcessing, which
// covers the character keys (spacebar, QWERTY) that
// AcceleratorKeyPressed does not fire for.
webViewController->add_AcceleratorKeyPressed (
Expand Down Expand Up @@ -1213,13 +1213,13 @@ class WebBrowserComponent::Impl::Platform::WebView2 final : public WebBrowserCom
return E_NOINTERFACE;
}

ComSmartPtr<ICoreWebView2ControllerOptions2> controllerOptions2;
controllerOptions.QueryInterface (controllerOptions2);
ComSmartPtr<ICoreWebView2ControllerOptions4> controllerOptions4;
controllerOptions.QueryInterface (controllerOptions4);

if (controllerOptions2 == nullptr)
if (controllerOptions4 == nullptr)
return E_NOINTERFACE;

if (controllerOptions2->put_AllowHostInputProcessing (TRUE) != S_OK)
if (controllerOptions4->put_AllowHostInputProcessing (TRUE) != S_OK)
return E_FAIL;

return environment10->CreateCoreWebView2ControllerWithOptions (hostHwnd,
Expand Down
Loading