WebView (Windows): use ICoreWebView2ControllerOptions4 for AllowHostInputProcessing#27
Merged
jakepenn merged 1 commit intoMay 23, 2026
Conversation
…tInputProcessing The keyboard-passthrough patch was querying ICoreWebView2ControllerOptions2, but that interface only exposes ScriptLocale. put_AllowHostInputProcessing lives on ICoreWebView2ControllerOptions4 (introduced in WebView2 Win32 SDK 1.0.3351.48, well below our pinned 1.0.3485.44). Without this fix the Windows Player build fails with: no member named 'put_AllowHostInputProcessing' in 'ICoreWebView2ControllerOptions2' Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ICoreWebView2ControllerOptions2, which only exposesScriptLocale.put_AllowHostInputProcessinglives onICoreWebView2ControllerOptions4(introduced in WebView2 Win32 SDK 1.0.3351.48 — well below our CI-pinned 1.0.3485.44).Why CI didn't catch this
PRs #25 and #26 didn't run the Release Player workflow that builds Windows; the failure first surfaced when
Release Playerwas dispatched againstmain(https://github.com/Minimal-Audio/minimal_core/actions/runs/26317655858/job/77480189355).Build error before fix
```
juce_WebBrowserComponent_windows.cpp:1222:41:
error: no member named 'put_AllowHostInputProcessing' in 'ICoreWebView2ControllerOptions2'
```
Test plan
🤖 Generated with Claude Code