Skip to content

Add Intel OneAPI Fortran compiler support to mpif90.mk include file#359

Open
Wolfgang Hayek (tinyendian) wants to merge 3 commits into
MetOffice:mainfrom
tinyendian:354_add_ifx_icpx_to_mpi_wrappers
Open

Add Intel OneAPI Fortran compiler support to mpif90.mk include file#359
Wolfgang Hayek (tinyendian) wants to merge 3 commits into
MetOffice:mainfrom
tinyendian:354_add_ifx_icpx_to_mpi_wrappers

Conversation

@tinyendian
Copy link
Copy Markdown

@tinyendian Wolfgang Hayek (tinyendian) commented May 4, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Cameron Bateman (@cameronbateman-mo)

This PR adds the Intel OneAPI Fortran compiler ifx to the list of known compilers in the mpif90.mk include file used by the LFRic build system, closing #354. The addition of ifx is a prerequisite for MetOffice/lfric_apps#468 / MetOffice/lfric_apps#477.

While I originally planned to add ifx to the mpifort.mk and icpx to mpic++.mk include files, it turned out that Intel OneAPI MPI does not support the corresponding wrappers, so I cannot test these changes.

There is currently no ESNZ site configuration available for lfric_core to test the change, but I successfully ran LFRic Apps Rose Stem tests using this branch in MetOffice/lfric_apps#477.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Not available - ESNZ site configuration currently not available for Rose Stem.

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@tinyendian Wolfgang Hayek (tinyendian) force-pushed the 354_add_ifx_icpx_to_mpi_wrappers branch from e41cd3f to 1147c1a Compare May 4, 2026 04:04
@tinyendian Wolfgang Hayek (tinyendian) requested a review from a team as a code owner May 4, 2026 04:04
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels May 4, 2026
@tinyendian
Copy link
Copy Markdown
Author

Should be good to go - reassigning to Matthew Hambley (@MatthewHambley) for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants