Add Intel OneAPI Fortran compiler support to mpif90.mk include file#359
Open
Wolfgang Hayek (tinyendian) wants to merge 3 commits into
Open
Add Intel OneAPI Fortran compiler support to mpif90.mk include file#359Wolfgang Hayek (tinyendian) wants to merge 3 commits into
Wolfgang Hayek (tinyendian) wants to merge 3 commits into
Conversation
e41cd3f to
1147c1a
Compare
Author
|
Should be good to go - reassigning to Matthew Hambley (@MatthewHambley) for review |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Cameron Bateman (@cameronbateman-mo)
This PR adds the Intel OneAPI Fortran compiler
ifxto the list of known compilers in thempif90.mkinclude file used by the LFRic build system, closing #354. The addition ofifxis a prerequisite for MetOffice/lfric_apps#468 / MetOffice/lfric_apps#477.While I originally planned to add
ifxto thempifort.mkandicpxtompic++.mkinclude files, it turned out that Intel OneAPI MPI does not support the corresponding wrappers, so I cannot test these changes.There is currently no ESNZ site configuration available for
lfric_coreto test the change, but I successfully ran LFRic Apps Rose Stem tests using this branch in MetOffice/lfric_apps#477.Code Quality Checklist
Testing
trac.log
Not available - ESNZ site configuration currently not available for Rose Stem.
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review