Expand ESNZ Rose Stem Tests#477
Open
Wolfgang Hayek (tinyendian) wants to merge 2 commits into
Open
Conversation
0c28718 to
aa76227
Compare
Contributor
Author
|
This PR should be good to go - Matthew Hambley (@MatthewHambley), Joerg Henrichs (@hiker), and thomasmelvin are you happy with the changes? Who should I ask for SR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Sam Clarke-Green (@t00sa)
This PR expands ESNZ Rose Stem testing for LFRic Apps to cover additional test cases and miniapps, closing #468. It also updates the ESNZ site configuration, LFRic build system, and Rose Stem apps to enable these tests:
Changes in common directories:
ifx.mkinclude file adds support for the Intel OneAPI Fortran compiler tongarchminiapp buildsncap2utility on ESNZ's Cascade HPC requires setting flag-Afor appending files explicitly; this should not affect other sites where this flag seems to be optional.This PR depends on MetOffice/lfric_core#359.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric_apps_468_expand_esnz_testing/run1
Suite Information
Task Information
✅ succeeded tasks - 243
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review