Skip to content

Expand ESNZ Rose Stem Tests#477

Open
Wolfgang Hayek (tinyendian) wants to merge 2 commits into
MetOffice:mainfrom
tinyendian:468_expand_esnz_testing
Open

Expand ESNZ Rose Stem Tests#477
Wolfgang Hayek (tinyendian) wants to merge 2 commits into
MetOffice:mainfrom
tinyendian:468_expand_esnz_testing

Conversation

@tinyendian
Copy link
Copy Markdown
Contributor

@tinyendian Wolfgang Hayek (tinyendian) commented May 4, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Sam Clarke-Green (@t00sa)

This PR expands ESNZ Rose Stem testing for LFRic Apps to cover additional test cases and miniapps, closing #468. It also updates the ESNZ site configuration, LFRic build system, and Rose Stem apps to enable these tests:

Changes in common directories:

  • A new ifx.mk include file adds support for the Intel OneAPI Fortran compiler to ngarch miniapp builds
  • The NCO ncap2 utility on ESNZ's Cascade HPC requires setting flag -A for appending files explicitly; this should not affect other sites where this flag seems to be optional.

This PR depends on MetOffice/lfric_core#359.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - lfric_apps_468_expand_esnz_testing/run1

Suite Information

Item Value
Suite Name lfric_apps_468_expand_esnz_testing/run1
Suite User hayekws
Workflow Start 2026-05-04T21:08:57
Groups Run all
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules MetOffice/jules@2026.03.2 True
lfric_apps tinyendian/lfric_apps@468_expand_esnz_testing False
lfric_core tinyendian/lfric_core@354_add_ifx_icpx_to_mpi_wrappers False
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@cab3315 True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@1cdb9c2 True

Task Information

✅ succeeded tasks - 243

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@tinyendian
Copy link
Copy Markdown
Contributor Author

This PR should be good to go - Matthew Hambley (@MatthewHambley), Joerg Henrichs (@hiker), and thomasmelvin are you happy with the changes? Who should I ask for SR? Thanks!

Copy link
Copy Markdown
Contributor

@thomasmelvin thomasmelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants