Repository navigation
merge queue: checking #1887 on main (1d677f9) - #1889
Closed
mergify[bot] wants to merge 2 commits into
Closed
mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
`mergify auth login` sends the machine's hostname as `device_name` so the approval page can default the token name to this machine. Hostnames often carry a person's name, and `POST /v1/oauth/device/code` is unauthenticated: the value sits on the pending grant server-side before anyone approves, so editing the field on the page does not un-send it. It is also a poor label for someone with several machines on one account. `--device-name NAME` replaces the detected hostname and is sent as typed; the server caps and sanitizes it. A blank value (`--device-name=`, which also survives Windows PowerShell 5.1 dropping a `""` argument) sends no name at all, the same request a machine that cannot name itself already makes, and the server keeps its own default label. Without the flag nothing changes. Fixes MRGFY-9268 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Change-Id: If4f977008ded4d2acd0cb1ce5492c60c3f4df4e3
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#1887 is queued for merge on branch main (1d677f9).
This pull request has been created by Mergify to check the mergeability of #1887.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub branch protection]auth login --device-nameto override the hostname #1887github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]auth login --device-nameto override the hostname #1887Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:auth login --device-nameto override the hostname #1887👀 Review Requirements]:#approved-reviews-by>=2auth login --device-nameto override the hostname #1887author = dependabot[bot]auth login --device-nameto override the hostname #1887author = mergify-ci-botauth login --device-nameto override the hostname #1887author = renovate[bot]auth login --device-nameto override the hostname #1887📕 PR description]:body ~= (?ms:.{48,})auth login --device-nameto override the hostname #1887🔎 Reviews]:#changes-requested-reviews-by = 0auth login --device-nameto override the hostname #1887#review-requested = 0auth login --device-nameto override the hostname #1887#review-threads-unresolved = 0auth login --device-nameto override the hostname #1887🤖 Continuous Integration]:check-success=ci-gateRequired conditions to stay in the queue:
base=mainauth login --device-nameto override the hostname #1887github-review-approved[🛡 GitHub branch protection]auth login --device-nameto override the hostname #1887github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]auth login --device-nameto override the hostname #1887label!=manual mergeauth login --device-nameto override the hostname #1887Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:auth login --device-nameto override the hostname #1887👀 Review Requirements]:#approved-reviews-by>=2auth login --device-nameto override the hostname #1887author = dependabot[bot]auth login --device-nameto override the hostname #1887author = mergify-ci-botauth login --device-nameto override the hostname #1887author = renovate[bot]auth login --device-nameto override the hostname #1887📕 PR description]:body ~= (?ms:.{48,})auth login --device-nameto override the hostname #1887🔎 Reviews]:#changes-requested-reviews-by = 0auth login --device-nameto override the hostname #1887#review-requested = 0auth login --device-nameto override the hostname #1887#review-threads-unresolved = 0auth login --device-nameto override the hostname #1887🤖 Continuous Integration]:check-success=ci-gateauth login --device-nameto override the hostname #1887