Repository navigation
feat(auth): add auth login --device-name to override the hostname - #1887
Merged
Conversation
`mergify auth login` sends the machine's hostname as `device_name` so the approval page can default the token name to this machine. Hostnames often carry a person's name, and `POST /v1/oauth/device/code` is unauthenticated: the value sits on the pending grant server-side before anyone approves, so editing the field on the page does not un-send it. It is also a poor label for someone with several machines on one account. `--device-name NAME` replaces the detected hostname and is sent as typed; the server caps and sanitizes it. A blank value (`--device-name=`, which also survives Windows PowerShell 5.1 dropping a `""` argument) sends no name at all, the same request a machine that cannot name itself already makes, and the server keeps its own default label. Without the flag nothing changes. Fixes MRGFY-9268 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Change-Id: If4f977008ded4d2acd0cb1ce5492c60c3f4df4e3
Contributor
Merge Protections🟢 All 6 merge protections satisfied — ready to merge. Show 6 satisfied protections🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change preserves default behavior, covers override and opt-out cases, and has no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds auth login --device-name so users can replace the hostname sent during device authorization or omit it for privacy.
Changes:
- Wires the option through CLI dispatch and login, preserving hostname detection when omitted.
- Adds override and blank-value tests, updates help snapshots, and documents usage.
| File | Description |
|---|---|
| README.md | Documents custom names and hostname opt-out. |
| crates/mergify-cli/src/snapshots/mergify__tests__cli_schema_golden.snap | Records the new option’s CLI schema. |
| crates/mergify-cli/src/main.rs | Parses, dispatches, and tests the option. |
| crates/mergify-auth/src/login.rs | Applies the override or omission and tests request bodies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kozlek
approved these changes
Oct 6, 2026
remyduthu
approved these changes
Oct 6, 2026
Contributor
Merge Queue Status
This pull request spent 8 minutes 25 seconds in the queue, including 8 minutes 6 seconds running CI. Required conditions to merge
|
34 of 40 tasks
mergify
Bot
deleted the
devs/sileht/mrgfy-9268-auth-login-device-name/add-auth-login-device-name-override-hostname--f4f97700
branch
October 6, 2026 07:53
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mergify auth loginsends the machine's hostname asdevice_nameso theapproval page can default the token name to this machine. Hostnames often
carry a person's name, and
POST /v1/oauth/device/codeis unauthenticated:the value sits on the pending grant server-side before anyone approves, so
editing the field on the page does not un-send it. It is also a poor label
for someone with several machines on one account.
--device-name NAMEreplaces the detected hostname and is sent as typed;the server caps and sanitizes it. A blank value (
--device-name=, whichalso survives Windows PowerShell 5.1 dropping a
""argument) sends noname at all, the same request a machine that cannot name itself already
makes, and the server keeps its own default label. Without the flag
nothing changes.
Fixes MRGFY-9268
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com