feat: Add extension to open customtab browser#759
Merged
baillyjamy merged 3 commits intomainfrom May 6, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Context extension to open URLs in an Android Custom Tab and updates the Privacy Management screen to use it for the “Source code” link.
Changes:
- Added
Context.openUrlInCustomTab(url)inCommon(usingandroidx.browserCustom Tabs). - Updated
PrivacyManagementHomeContentto open the source URL via Custom Tabs instead of a generic browser intent. - Added
androidx.browser:browserto the version catalog andCommonmodule dependencies.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PrivacyManagement/src/main/kotlin/com/infomaniak/core/privacymanagement/screencontent/PrivacyManagementHomeContent.kt | Switches the source button click action to use the new Custom Tab URL opener. |
| gradle/core.versions.toml | Adds the androidx.browser library and its version to the catalog. |
| Common/src/main/kotlin/com/infomaniak/core/common/extensions/ContextExt.kt | Adds openUrlInCustomTab extension (currently without the same safety/fallback behavior as openUrl). |
| Common/build.gradle.kts | Adds the androidx.browser dependency to support Custom Tabs usage in Common. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
approved these changes
May 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extension to open customtab browser