Skip to content

feat: Use CustomTab instead of open url#168

Merged
baillyjamy merged 2 commits into
mainfrom
feat-customtab-browser
May 6, 2026
Merged

feat: Use CustomTab instead of open url#168
baillyjamy merged 2 commits into
mainfrom
feat-customtab-browser

Conversation

@baillyjamy
Copy link
Copy Markdown
Contributor

@baillyjamy baillyjamy commented May 6, 2026

Use CustomTab instead of open url

Depends on Infomaniak/android-core#759

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the app’s external link handling to open URLs via Chrome Custom Tabs instead of the previous generic URL opening helper, improving in-app browsing consistency and UX.

Changes:

  • Replace openUrl(...) with openUrlInCustomTab(...) for feedback/support links in Settings.
  • Replace openUrl(...) with openUrlInCustomTab(...) for support links shown in the “Action required” UI.
  • Update the shared OpenUrlButton component to open its URL in a Custom Tab.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
app/src/main/kotlin/com/infomaniak/auth/ui/screen/settings/SettingsScreen.kt Switch Settings feedback/support links to open in Custom Tabs.
app/src/main/kotlin/com/infomaniak/auth/ui/screen/accountdetails/ActionRequiredCard.kt Switch support link actions to open in Custom Tabs.
app/src/main/kotlin/com/infomaniak/auth/ui/components/OpenUrlButton.kt Update reusable URL button to open in a Custom Tab.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions Bot removed the dependent label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

This PR/issue depends on:

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@baillyjamy baillyjamy merged commit b0b758a into main May 6, 2026
9 checks passed
@baillyjamy baillyjamy deleted the feat-customtab-browser branch May 6, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants