feat: Use CustomTab instead of open url#168
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the app’s external link handling to open URLs via Chrome Custom Tabs instead of the previous generic URL opening helper, improving in-app browsing consistency and UX.
Changes:
- Replace
openUrl(...)withopenUrlInCustomTab(...)for feedback/support links in Settings. - Replace
openUrl(...)withopenUrlInCustomTab(...)for support links shown in the “Action required” UI. - Update the shared
OpenUrlButtoncomponent to open its URL in a Custom Tab.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/kotlin/com/infomaniak/auth/ui/screen/settings/SettingsScreen.kt | Switch Settings feedback/support links to open in Custom Tabs. |
| app/src/main/kotlin/com/infomaniak/auth/ui/screen/accountdetails/ActionRequiredCard.kt | Switch support link actions to open in Custom Tabs. |
| app/src/main/kotlin/com/infomaniak/auth/ui/components/OpenUrlButton.kt | Update reusable URL button to open in a Custom Tab. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
approved these changes
May 6, 2026
Contributor
|
This PR/issue depends on:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Use CustomTab instead of open url
Depends on Infomaniak/android-core#759