Repository navigation
fix(mcp): serve entry points exit with the mcp-extra hint, not a traceback - #56
Merged
Merged
Conversation
…eback Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
… tests - main() now guards only build_server(): an ImportError while building the app is the missing-extra case (hint on stderr, exit 1); a startup ImportError from .run() propagates with its traceback instead of being mislabeled. - New tests block mcp in sys.modules so the real _make_app import chain produces the exit — stubbed build_server could not catch a broken hint or a leaked traceback path. - Changelog entries for devkit and skill-catalog.
github-actions
Bot
added
the
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Regression test for the changed behavior: a stub server whose run() raises ImportError must propagate the traceback rather than exit 1 with the missing-extra hint. One test per package entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both MCP server entry points (
devin-devkit-mcp,devin-skill-catalog-mcp) calledbuild_server().run(transport="stdio")bare, so a missingmcpextra surfaced as a raw ImportError traceback instead of the install hint_make_appalready raises.Wrap the
.run()call in eachmain(): on ImportError, printerror: {exc}to stderr and exit 1 — the published devin_memory pattern.Adds
test_main_missing_mcp_extra_exits_with_hintto bothtests/test_mcp.pyfiles (monkeypatchesbuild_serverto raise, asserts SystemExit(1), stderr contains the hint, no traceback).Tests:
pytest tests/test_mcp.py— 12 passed / 11 passed (+1 skipped each: mcp extra not installed).Generated with Devin