使用 LineSelectButton 代替 JFXComboxBox #5337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
实测换行问题还在。 另外，字体选择框有计划实现吗？ |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/ComponentList.java:106
- getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
public ObservableList<Node> getContent() {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1868
to
1877
| .line-select-button .menu-container .title { | ||
| -fx-font-size: 13px; | ||
| -fx-text-fill: -monet-on-surface; | ||
| } | ||
|
|
||
| .line-select-button .menu-container:selected .title { | ||
| -fx-text-fill: -monet-primary; | ||
| } | ||
|
|
||
| .line-select-button .popup-menu .subtitle { |
There was a problem hiding this comment.
这些样式选择器以 .line-select-button ... 作为祖先限定，但 LineSelectButton 的下拉菜单是通过 JFXPopup 在独立的 PopupWindow/Scene 中显示的，因此 .menu-container / .popup-menu 节点通常不会是 .line-select-button 的后代，导致这些规则不生效。建议改为基于 .popup-menu（或给该 PopupMenu 额外加一个专用 style class 再在 CSS 中选择）来定义标题/选中态/副标题样式。
Suggested change
| .line-select-button .menu-container .title { | |
| -fx-font-size: 13px; | |
| -fx-text-fill: -monet-on-surface; | |
| } | |
| .line-select-button .menu-container:selected .title { | |
| -fx-text-fill: -monet-primary; | |
| } | |
| .line-select-button .popup-menu .subtitle { | |
| .popup-menu .menu-container .title { | |
| -fx-font-size: 13px; | |
| -fx-text-fill: -monet-on-surface; | |
| } | |
| .popup-menu .menu-container:selected .title { | |
| -fx-text-fill: -monet-primary; | |
| } | |
| .popup-menu .subtitle { |
HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/LineSelectButton.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/LineSelectButton.java
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/ComponentList.java:106
- getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
getContent exposes the internal representation stored in field content. The value may be modified after this call to getContent.
public ObservableList<Node> getContent() {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+204
to
+208
| private final ListProperty<T> items = new SimpleListProperty<>(this, "items", FXCollections.emptyObservableList()); | ||
|
|
||
| public ListProperty<T> itemsProperty() { | ||
| return items; | ||
| } |
There was a problem hiding this comment.
items 的默认值使用了 FXCollections.emptyObservableList()（不可修改）。如果外部代码调用 getItems().add(...)/getItems().setAll(...) 会直接抛 UnsupportedOperationException。作为可复用控件的公开 API，建议默认使用可变的 FXCollections.observableArrayList()（或在 getItems() 返回前确保可变）。
| popup.hide(); | ||
| }); | ||
|
|
||
| FXUtils.onChangeAndOperate(valueProperty(), |
There was a problem hiding this comment.
这里为每个菜单项都用 FXUtils.onChangeAndOperate(valueProperty(), ...) 给 LineSelectButton.valueProperty() 添加了一个强引用监听器。菜单项节点被移除/重建时（items 变化、页面销毁）这些监听器不会自动移除，可能导致节点无法被 GC（内存泄漏）并造成不必要的更新开销。建议改用弱监听（如 FXUtils.onWeakChangeAndOperate/WeakChangeListener），或在菜单项节点生命周期结束时显式移除监听器。
Suggested change
| FXUtils.onChangeAndOperate(valueProperty(), | |
| FXUtils.onWeakChangeAndOperate(valueProperty(), |
HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/LineSelectButton.java
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本 PR 实现了一个新控件
LineSelectButton用于替代JFXComboxBox：