-
Notifications
You must be signed in to change notification settings - Fork 130
feat(lyrics): add notification lyrics support #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c267564
58700a2
ea209df
fe78174
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -155,6 +155,8 @@ | |
| <string name="tab_order_summary">应用将在启动时显示第一个标签页。分隔线后的标签页将被隐藏。</string> | ||
| <string name="settings_status_bar_lyrics_title">状态栏歌词</string> | ||
| <string name="settings_status_bar_lyrics_summary">启用魅族状态栏歌词(仅适用于部分设备)</string> | ||
| <string name="settings_notification_lyrics_title">通知栏歌词</string> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for contributing translations for the new feature! However, the automated script that updates changes would override the change and delete the translation. Translations have to be contributed through Weblate for the workflow to work - and this can only be done after english strings in PR was merged.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. well-- i speak chinese and i add it for testing and self use :) |
||
| <string name="settings_notification_lyrics_summary">在媒体通知中显示当前播放歌词</string> | ||
| <string name="settings_lyrics_ui">启用新歌词界面</string> | ||
| <string name="lyric_widget_description">显示当前播放媒体歌词的小部件</string> | ||
| <string name="scroll_to_albums">滚动到专辑</string> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if it works with setDisplayTitle+setSubtitle but without setTitle+setArtist?
Reason I'm asking: apps like Pano Scrobbler might not work when changing title/artist
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gramophone-1.1.2.1666f33-release.apk.zip
snapshot.tar.gz
I forked out and added another switch, compcompiled one for my phone, but that seems glichey, and edit notification seems unstable.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android 7, which higher than minsdk, unsupport this.
Android 16, which brought by OEM, will flickers and displays erratically, as if it's unsure which indicator to follow.
https://github.com/nift4/media/blob/5fcf02d05e7e840e12274473420f6268d2cd2925/libraries/session/src/main/java/androidx/media3/session/DefaultMediaNotificationProvider.java#L601-L635
Perhaps we can explain the destructive nature of this function within the response switch itself.