feat(lyrics): add notification lyrics support - #1005
Conversation
495b22b to
58700a2
Compare
|
Hi, is this intended for use with bluetooth cars and Android Auto mainly, or also for phone usage? I am wondering whether it should be restricted to the Bluetooth and AA session, so that the notification in phone UI continues to not show lyrics. |
First of all, embarrassingly, I don't have a car yet, and I don't have a device that can display Bluetooth media names. So I cant promise that 100% works. However, my WearOS watch displays lyrics correctly, so I'm not sure if both of these are working correctly. 
|
|
Additionally, this feature is only available after the lyrics notification switch in Settings - Player - Lyrics is manually turned on. As far as I know, modifying the publicly announced name of the playback media to display lyrics is a fairly common practice, or at least that's how the commercial streaming media I use works. I added this feature because it works well with the manufacturer's fluid cloud and offers an experience almost identical to commercial software. 
|
|
Makes sense, then we can keep it for phone too. |
| <string name="tab_order_summary">应用将在启动时显示第一个标签页。分隔线后的标签页将被隐藏。</string> | ||
| <string name="settings_status_bar_lyrics_title">状态栏歌词</string> | ||
| <string name="settings_status_bar_lyrics_summary">启用魅族状态栏歌词（仅适用于部分设备）</string> | ||
| <string name="settings_notification_lyrics_title">通知栏歌词</string> |
There was a problem hiding this comment.
Thanks for contributing translations for the new feature! However, the automated script that updates changes would override the change and delete the translation. Translations have to be contributed through Weblate for the workflow to work - and this can only be done after english strings in PR was merged.
There was a problem hiding this comment.
well-- i speak chinese and i add it for testing and self use :)
i will submit to weblate after merged. Thanks for notice!
|
@nift4 If this is merged, Xiaomi Media Island will be able to share real-time lyrics. |
…and streamline updates
…id repeated lookups
| } | ||
| val metadataWithLyric = superState.currentMetadata.buildUpon() | ||
| .setTitle(notifLyric) | ||
| .setArtist(subtitle) |
There was a problem hiding this comment.
Do you know if it works with setDisplayTitle+setSubtitle but without setTitle+setArtist?
Reason I'm asking: apps like Pano Scrobbler might not work when changing title/artist
There was a problem hiding this comment.
Gramophone-1.1.2.1666f33-release.apk.zip
snapshot.tar.gz
I forked out and added another switch, compcompiled one for my phone, but that seems glichey, and edit notification seems unstable.
There was a problem hiding this comment.
Android 7, which higher than minsdk, unsupport this.
Android 16, which brought by OEM, will flickers and displays erratically, as if it's unsure which indicator to follow.
Perhaps we can explain the destructive nature of this function within the response switch itself.
|
Thanks for the PR! |
3 participants
Summary
Notification lyrics — opt-in setting that surfaces the current synced lyric line in both the expanded media notification and the system media session metadata (lockscreen / BT / Android Auto), with the original title+artist preserved as the subtitle line.
Screenshots, CI tests and more, see #1003