Skip to content

Fix use-after-free when mic and system transcription run concurrently #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex-Wengg merged 3 commits into from
Apr 1, 2026
Merged

Fix use-after-free when mic and system transcription run concurrently #473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bb25e7
Fix use-after-free when mic and system transcription run concurrently
dloomis Mar 30, 2026
b422fbf
Fix same race in transcribeDiskBacked
dloomis Mar 30, 2026
7f2a1ff
Merge branch 'main' into fix/concurrent-decoder-state-reset
Alex-Wengg Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/FluidAudio/ASR/Parakeet/AsrManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ public actor AsrManager {

sampleSource.cleanup()

try await self.resetDecoderState()
try await self.resetDecoderState(for: source)
if shouldEmitProgress {
await progressEmitter.finishSession()
}
Expand Down Expand Up @@ -432,9 +432,9 @@ public actor AsrManager {
do {
let result = try await transcribeWithState(audioSamples, source: source)

// Stateless architecture: reset decoder state after each transcription to ensure
// independent processing for batch operations without state carryover
try await self.resetDecoderState()
// Reset only the source we just used — resetting both races with a
// concurrent transcription on the other source and frees in-flight MLMultiArrays.
try await self.resetDecoderState(for: source)
if shouldEmitProgress {
await progressEmitter.finishSession()
}
Expand Down
Loading