Fix use-after-free when mic and system transcription run concurrently#473
Merged
Alex-Wengg merged 3 commits intoFluidInference:mainfrom Apr 1, 2026
Merged
Conversation
resetDecoderState() resets both mic and system decoder states. When two sources transcribe concurrently, whichever finishes first frees the other source's in-flight MLMultiArray objects (hidden/cell states), causing EXC_BAD_ACCESS in the autorelease pool on the cooperative thread pool. Only reset the decoder state for the source that just completed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Also calls resetDecoderState() (both sources) after completion. Apply the same per-source fix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Alex-Wengg
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transcribe(_:source:)callsresetDecoderState()after each transcription, which resets both mic and system decoder states. When two sources transcribe concurrently (e.g. mic + system audio in a meeting recorder), whichever task finishes first frees the other source's in-flightMLMultiArrayobjects (hidden/cell states), causingEXC_BAD_ACCESSin the autorelease pool on the cooperative thread pool.resetDecoderState(for: source)instead, so only the completed source's state is reset.Crash details
Register
x1referencedOBJC_CLASS_$_MLMultiArray; poison values0xa1a1a1a1/0xa3a3a3a3confirmed use-after-free.Test plan
🤖 Generated with Claude Code