zhTW: translate 46 new keys and unify threshold wording - #1121
Closed
LoChinAn wants to merge 3 commits into
Closed
Conversation
Covers Merge Duplicate Items (Bags), Custom Duration Format warning (Unit Frames), Bar/Bars pluralization (CDM), Voidforged track name (QoL Upgrade Calculator), and the SPECIAL UPDATE eyebrow badge.
Covers the friendly nameplate subtitle (title/guild), charge count hiding on action buttons and the cooldown manager, Always Show Pet Frame, and the battle-res tracker's display style, font outline and color options. Also adds disabledTooltip strings that were never collected before: they are returned from inside `disabledTooltip = function() ... end`, which the key scanner classified too weakly to surface. Replaces 閾值 with 臨界值 or 門檻 in seven existing entries so each one matches the term already used by the neighbouring options in its panel.
LoChinAn
force-pushed
the
zhtw-sync-2026-08-01
branch
from
August 1, 2026 13:36
9ab2a53 to
59ffa1b
Compare
LoChinAn
changed the title
Seven more keys, from options text the key scanner could not classify until now: five subnav labels in the cooldown manager passed positionally to a module-local helper, and two resource-bar tooltips hoisted into a local before being used as a field value. Ignore Pain is 無視苦痛 and Sweeping Strikes is 橫掃攻擊, both per the in-game Traditional Chinese names.
LoChinAn
changed the title
Contributor
Author
|
Because it's significantly behind the main branch, to avoid conflicts, I will open a new PR after closing this one. |
EllesmereGaming
added a commit
that referenced
this pull request
Aug 3, 2026
zhTW: translate 89 new keys (supersedes #1121)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Traditional Chinese for 46 keys and corrects 7 existing ones.
New keys come from two sources:
charge count hiding on action buttons and the cooldown manager, Always Show
Pet Frame, and the battle-res tracker's display style, font outline and
color options.
inside
disabledTooltip = function() ... end, strings hoisted into a localbefore being used as a field value, and labels passed positionally to
module-local helpers. All of them reach
EllesmereUI.L()at render time, sothey were always translatable; they just never showed up as candidates.
Also normalizes Threshold wording: 閾值 is replaced by 臨界值 or 門檻 so each
entry matches the term already used by the neighbouring options in its panel.
Rebased onto v8.7.1. Only
Locales/zhTW.luais touched.