zhTW: translate 89 new keys (supersedes #1121) - #1168
Merged
EllesmereGaming merged 7 commits intoAug 3, 2026
Conversation
Covers Merge Duplicate Items (Bags), Custom Duration Format warning (Unit Frames), Bar/Bars pluralization (CDM), Voidforged track name (QoL Upgrade Calculator), and the SPECIAL UPDATE eyebrow badge.
Covers the friendly nameplate subtitle (title/guild), charge count hiding on action buttons and the cooldown manager, Always Show Pet Frame, and the battle-res tracker's display style, font outline and color options. Also adds disabledTooltip strings that were never collected before: they are returned from inside `disabledTooltip = function() ... end`, which the key scanner classified too weakly to surface. Replaces 閾值 with 臨界值 or 門檻 in seven existing entries so each one matches the term already used by the neighbouring options in its panel.
Seven more keys, from options text the key scanner could not classify until now: five subnav labels in the cooldown manager passed positionally to a module-local helper, and two resource-bar tooltips hoisted into a local before being used as a field value. Ignore Pain is 無視苦痛 and Sweeping Strikes is 橫掃攻擊, both per the in-game Traditional Chinese names.
Covers the Edit Mode manual-fix popup (CDM), Blizzard atlas bar artwork and split backgrounds (Resource Bars), vertical health bar fill (Unit and Raid Frames), friendly nameplate title/guild subtitle, the countdown size cap (Action Bars), the breakdown tooltip anchor (Damage Meters) and the currency description toggle (DataBars). The CDM popup message is built by concatenation and reaches L() as one string, so the whole assembled message is the key -- not the leading fragment the key scanner reported. Blizzard Edit Mode element names in it follow the official zhTW GlobalStrings, since the steps tell the user what to look for in Blizzard's own interface. Also adds Recolor Text Instead Of Bar, which was never translated: the new atlas warning points at it by name.
These are concatenated strings: the fragments reach L() already joined, so the key is the whole assembled sentence. harvest.py returned only the head fragment until now, which is why they read as missing. Covers the graphics optimizer panel, the Item Upgrade calculator's two button tooltips, the Resource Bars multi-band and buff-recolor help tips, the Unlock Mode grow-direction hint and the CDM custom-spell notice. Where a head fragment was already translated, the assembled entry reuses that wording verbatim. Blizzard graphics setting names follow the official zhTW GlobalStrings.
Prefers 計量條 over 長條, 門檻 over 臨界值 and 浮動提示 over 提示資訊 in these two entries, and keeps % as the symbol rather than spelling it out.
The refresh tooltip quotes this button by name, so the button's own entry has to read the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1121, which was opened against v8.7.1 and had fallen 65 commits
behind. Same three commits rebuilt on current
main, plus new work foreverything that landed in v8.7.2 - v8.7.4. Only
Locales/zhTW.luaistouched: 104 lines added, 8 rewritten in place (the wording fixes noted
below). 96 keys in total.
From #1121 (46 keys)
Merge Duplicate Items, Custom Duration Format, CDM bar pluralization, the
Voidforged track name, friendly nameplate subtitles, charge-count hiding,
Always Show Pet Frame and the battle-res tracker. Also unified 閾值 to
臨界值 / 門檻 in seven existing entries so each matches the wording its
neighbouring options already use.
v8.7.2 - v8.7.4 (43 keys)
backgrounds, texture settings
the icon crop slider
icon and item ID toggles, tab layout, the mailbox note added to Auto
Open Containers
Strings assembled from concatenation (7 keys)
A
..chain reachesL()already joined, so the catalog key is the wholeassembled sentence rather than its leading fragment. Our key scanner only
returned the fragment, so these read as translated when they were not:
Where a fragment was already translated the assembled entry reuses that
wording verbatim, and Blizzard graphics setting names follow the official
zhTW GlobalStrings.
Notes for reviewers
Blizzard's Edit Mode element names inside the CDM popup use the official
zhTW GlobalStrings (追蹤的增益效果, 追蹤的量條, 未啟用時隱藏, 能見度,
隨時可見) rather than EllesmereUI's own wording for its similar options -
the steps tell the user what to look for in Blizzard's interface, so they
have to match what is on screen there.
Recolor Text Instead Of Baris also added. It predates this batch and wasnever translated, but the new Blizzard atlas warning refers to it by name.
Update at Upgraderis reworded for the same reason: the upgrade refreshtooltip quotes that button, so both now read 在升級師處更新.