feat: upgrade NX and migrate builds to esbuild

.cursor/worktrees.json

@@ -0,0 +1,3 @@
+{
+    "setup-worktree": ["yarn install"]
+}

.github/workflows/nx-affected-e2e.yml

@@ -1,45 +1,48 @@
 name: Nx Affected E2E
 on:
-    pull_request:
-        branches: [main]
+  pull_request:
+    branches: [main]
 jobs:
-    build:
-        runs-on: ubicloud-standard-8
-        permissions:
-          contents: read
-          id-token: write
-          pull-requests: write
-          issues: write
-        strategy:
-            matrix:
-                node-version: [22.12]
-        steps:
-            - uses: actions/checkout@v4
-              with:
-                  fetch-depth: 0
-            - name: Enable Corepack
-              run: corepack enable
-            - name: Set Secrets
-              uses: DevCycleHQ/aws-secrets-action@main
-              with:
-                secrets_map: '{"NEXT_PUBLIC_E2E_OPTIN_CLIENT_KEY":"DEVCYCLE_GITHUB_js-sdks_NEXT_PUBLIC_E2E_OPTIN_CLIENT_KEY","E2E_OPTIN_SERVER_KEY":"DEVCYCLE_GITHUB_js-sdks_E2E_OPTIN_SERVER_KEY","NEXT_PUBLIC_E2E_EDGEDB_CLIENT_KEY":"DEVCYCLE_GITHUB_js-sdks_NEXT_PUBLIC_E2E_EDGEDB_CLIENT_KEY","E2E_EDGEDB_SERVER_KEY":"DEVCYCLE_GITHUB_js-sdks_E2E_EDGEDB_SERVER_KEY","E2E_NEXTJS_SERVER_KEY":"DEVCYCLE_GITHUB_js-sdks_E2E_NEXTJS_SERVER_KEY", "NEXT_PUBLIC_E2E_NEXTJS_CLIENT_KEY": "DEVCYCLE_GITHUB_js-sdks_NEXT_PUBLIC_E2E_NEXTJS_CLIENT_KEY", "DVC_E2E_SERVER_SDK_KEY": "DEVCYCLE_GITHUB_js-sdks_DVC_E2E_SERVER_SDK_KEY"}'
-                aws_account_id: '134377926370'
-            - name: Use Node.js ${{ matrix.node-version }}
-              uses: actions/setup-node@v4
-              with:
-                  node-version: ${{ matrix.node-version }}
-                  cache: 'yarn'
-            - run: git fetch origin main
-            - run: yarn --immutable
-            - name: Install Playwright Browsers
-              shell: bash
-              run: yarn playwright install --with-deps
-            - name: Run Affected E2E Tests
-              shell: bash
-              run: yarn affected:e2e
-            - name: Upload Playwright Report
-              if: always()
-              uses: actions/upload-artifact@v4
-              with:
-                  name: playwright-report
-                  path: dist/.playwright/e2e/
+  build:
+    runs-on: ubicloud-standard-8
+    permissions:
+      contents: read
+      id-token: write
+      pull-requests: write
+      issues: write
+    strategy:
+      matrix:
+        node-version: [22.12]
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Enable Corepack
+        run: corepack enable
+      - name: Set Secrets
+        uses: DevCycleHQ/aws-secrets-action@main
+        with:
+          secrets_map: '{"NEXT_PUBLIC_E2E_OPTIN_CLIENT_KEY":"DEVCYCLE_GITHUB_js-sdks_NEXT_PUBLIC_E2E_OPTIN_CLIENT_KEY","E2E_OPTIN_SERVER_KEY":"DEVCYCLE_GITHUB_js-sdks_E2E_OPTIN_SERVER_KEY","NEXT_PUBLIC_E2E_EDGEDB_CLIENT_KEY":"DEVCYCLE_GITHUB_js-sdks_NEXT_PUBLIC_E2E_EDGEDB_CLIENT_KEY","E2E_EDGEDB_SERVER_KEY":"DEVCYCLE_GITHUB_js-sdks_E2E_EDGEDB_SERVER_KEY","E2E_NEXTJS_SERVER_KEY":"DEVCYCLE_GITHUB_js-sdks_E2E_NEXTJS_SERVER_KEY", "NEXT_PUBLIC_E2E_NEXTJS_CLIENT_KEY": "DEVCYCLE_GITHUB_js-sdks_NEXT_PUBLIC_E2E_NEXTJS_CLIENT_KEY", "DVC_E2E_SERVER_SDK_KEY": "DEVCYCLE_GITHUB_js-sdks_DVC_E2E_SERVER_SDK_KEY"}'
+          aws_account_id: "134377926370"
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: "yarn"
+      - run: git fetch origin main
+      - run: yarn --immutable
+      - name: Install Playwright Browsers
+        shell: bash
+        run: yarn playwright install --with-deps
+      - name: Build shared libraries
+        shell: bash
+        run: yarn nx run-many -t build -p shared-types shared-bucketing server-request js-cloud-server-sdk nextjs js react --parallel=1
+      - name: Run Affected E2E Tests
+        shell: bash
+        run: yarn affected:e2e
+      - name: Upload Playwright Report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: playwright-report
+          path: dist/.playwright/e2e/

.gitignore

@@ -1,9 +1,11 @@
 node_modules
-.yarn/*
-!.yarn/patches
-!.yarn/plugins
-!.yarn/sdks
-!.yarn/versions
+**/.yarn/*
+!**/.yarn/patches
+!**/.yarn/plugins
+!**/.yarn/sdks
+!**/.yarn/versions
+.nx/cache
+.nx/workspace-data
 lerna-debug.log
 yarn-error.log
 .tmp/

.prettierignore

@@ -19,4 +19,5 @@ node_modules
 dev-apps/react/react-native-app/package.json
 .wrangler/
 *.html
-tmp/
+tmp/
+.nx/

AGENTS.md

@@ -2,67 +2,68 @@
 
 ## Configuration and Tooling
 
--   The project root contains configuration files for building, linting, formatting, and testing.
--   Key files include:
-    -   `package.json`: Project dependencies and scripts
-    -   `tsconfig.base.json`: Base TypeScript configuration
-    -   `jest.config.ts`: Jest test runner configuration
-    -   `.eslintrc.json`: ESLint configuration
-    -   `.prettierrc.json`: Prettier formatting rules
-    -   `nx.json`: NX workspace configuration
-    -   `project.json`: Project definitions for NX
+- always use `yarn` not `npm`
+- The project root contains configuration files for building, linting, formatting, and testing.
+- Key files include:
+  - `package.json`: Project dependencies and scripts
+  - `tsconfig.base.json`: Base TypeScript configuration
+  - `jest.config.ts`: Jest test runner configuration
+  - `.eslintrc.json`: ESLint configuration
+  - `.prettierrc.json`: Prettier formatting rules
+  - `nx.json`: NX workspace configuration
+  - `project.json`: Project definitions for NX
 
 ## Formatting
 
--   Defer all formatting to Prettier for supported file types (JavaScript, TypeScript, JSON, Markdown, etc.).
--   ESLint enforces code quality and linting rules.
+- Defer all formatting to Prettier for supported file types (JavaScript, TypeScript, JSON, Markdown, etc.).
+- ESLint enforces code quality and linting rules.
 
 ## Git Commit Message Conventions
 
--   Follow Conventional Commits specification: `<type>: <description>` or `<type>(<scope>): <description>` (scopes are optional and rarely used)
--   Valid types: `feat`, `fix`, `docs`, `style`, `refactor`, `perf`, `test`, `build`, `ci`, `chore`, `revert`
--   Description should be imperative mood, lowercase, single sentence.
--   Examples: `feat: add support for multi-threaded tests`, `fix: correct response for invalid input`, `docs: update README with new usage instructions`
+- Follow Conventional Commits specification: `<type>: <description>` or `<type>(<scope>): <description>` (scopes are optional and rarely used)
+- Valid types: `feat`, `fix`, `docs`, `style`, `refactor`, `perf`, `test`, `build`, `ci`, `chore`, `revert`
+- Description should be imperative mood, lowercase, single sentence.
+- Examples: `feat: add support for multi-threaded tests`, `fix: correct response for invalid input`, `docs: update README with new usage instructions`
 
 ## Internal Library Imports
 
--   Internal libraries should be imported using their package name (e.g., `@devcycle/bucketing`) rather than relative or absolute paths.
--   The package path for a library can be found in the library's `package.json` file under the `name` field.
--   This applies to code in `lib/`, `sdk/`, and test/script files are excluded.
--   **Example:**
-    -   Correct: `import { generateBucketedConfig } from '@devcycle/bucketing'`
-    -   Incorrect: `import { generateBucketedConfig } from '../../lib/shared/bucketing'`
+- Internal libraries should be imported using their package name (e.g., `@devcycle/bucketing`) rather than relative or absolute paths.
+- The package path for a library can be found in the library's `package.json` file under the `name` field.
+- This applies to code in `lib/`, `sdk/`, and test/script files are excluded.
+- **Example:**
+  - Correct: `import { generateBucketedConfig } from '@devcycle/bucketing'`
+  - Incorrect: `import { generateBucketedConfig } from '../../lib/shared/bucketing'`
 
 ## Naming Conventions
 
--   Files and variables should use camelCase (starting with lowercase).
--   Folders should use kebab-case.
+- Files and variables should use camelCase (starting with lowercase).
+- Folders should use kebab-case.
 
 ## Project Structure Guide
 
--   This repository is managed as an NX monorepo.
--   Main configuration files: `nx.json`, `project.json`, `package.json`, `tsconfig.base.json`, `jest.config.ts`
--   Source code organized under `lib/`, `sdk/`, and `dev-apps/` directories.
--   Shared types and utilities found in `lib/shared/`
--   Each project (library, SDK, or app) defined in its own directory under `lib/`, `sdk/`, or `dev-apps/`
--   NX commands used to build, test, and manage dependencies between projects.
+- This repository is managed as an NX monorepo.
+- Main configuration files: `nx.json`, `project.json`, `package.json`, `tsconfig.base.json`, `jest.config.ts`
+- Source code organized under `lib/`, `sdk/`, and `dev-apps/` directories.
+- Shared types and utilities found in `lib/shared/`
+- Each project (library, SDK, or app) defined in its own directory under `lib/`, `sdk/`, or `dev-apps/`
+- NX commands used to build, test, and manage dependencies between projects.
 
 ### README and Documentation
 
--   The main `README.md` at project root provides repository overview.
--   Many packages and libraries include their own README.md files with package-specific details.
+- The main `README.md` at project root provides repository overview.
+- Many packages and libraries include their own README.md files with package-specific details.
 
 ## Testing and Mocks
 
--   Source files in `lib/`, `sdk/`, should have corresponding test files.
--   Test and script files themselves are not required to have their own tests.
--   Test files: use `.spec.ts`, `.spec.js`, `.test.js`, or `.test.ts` suffixes. (prefer `.test.ts`)
--   Tests located in `__tests__/` directories or alongside source files.
--   Mock implementations placed in `__mocks__/` directories within each package or module.
+- Source files in `lib/`, `sdk/`, should have corresponding test files.
+- Test and script files themselves are not required to have their own tests.
+- Test files: use `.spec.ts`, `.spec.js`, `.test.js`, or `.test.ts` suffixes. (prefer `.test.ts`)
+- Tests located in `__tests__/` directories or alongside source files.
+- Mock implementations placed in `__mocks__/` directories within each package or module.
 
 ## Aviator CLI Workflow (optional)
 
--   Use Aviator CLI (`av`) for managing stacked branches: `av branch chore-fix-invalid-input`
--   Sync and push changes: `av sync --push=yes`
--   Create PR: `av pr --title "<title>" --body "<body>"`
-    -   title follows Conventional Commits, body uses markdown/bullets, `av pr` will push the branch
+- Use Aviator CLI (`av`) for managing stacked branches: `av branch chore-fix-invalid-input`
+- Sync and push changes: `av sync --push=yes`
+- Create PR: `av pr --title "<title>" --body "<body>"`
+  - title follows Conventional Commits, body uses markdown/bullets, `av pr` will push the branch

README.md

@@ -1,4 +1,5 @@
 ## JS SDK Monorepo
+
 This is the DevCycle JS SDK Monorepo which contains all the Javascript-based SDKs and public
 shared packages used by DevCycle products.
 
@@ -13,15 +14,16 @@ To view the README for a specific SDK, navigate to that SDK inside the `sdk` dir
 There are several examples included in this repository for various SDKs. If you want to run them, proceed to setup:
 
 ## Setup
+
 Ensure you have Node 22.x installed.
 
 1. Clone this repo
 2. Run `yarn` from the root directory. SDKs and dev-apps should now be set up to run via Nx.
 3. Run `aws configure sso`
 4. Run `aws sso login`
 
-
 ## Directory Structure
+
 ```
 dev-apps/
     - contains development test applications using each SDK
@@ -34,13 +36,15 @@ sdk/
 ```
 
 ## Running an development test app
+
 To run an app, use the `yarn start` command with the name of the example you want to run:
 `yarn start example-react-with-provider`
 
 The names of the dev-apps are listed in the `workspace.json` file at the root of the repository. All dev-apps are
 located in the root-level `dev-apps/` directory.
 
 ## Development
+
 The repo is managed using `Nx`, a monorepo management tool. It's worth reading their docs here:
 https://nx.dev/l/n/getting-started/intro
 
@@ -52,6 +56,7 @@ commands against them. For example, to test the "nodejs" project, run:
 These commands can be run from the root directory, but should work in any directory.
 
 The full list of relevant Nx commands is below:
+
 ```
 build - build the compiled Webpack output of the project
 serve - build and then run the compiled project
@@ -61,6 +66,7 @@ format:write - run prettier against the project and write all formatting changes
 ```
 
 There are also several root-level yarn commands for running services:
+
 ```
 yarn start                - start all services in the repo
 yarn start:partial        - start the services you specify (eg. yarn start:partial api,config)
@@ -102,9 +108,11 @@ You can run commands in every javascript project using Nx: `nx run-many --target
 This allows you to lint and/or test all projects at once.
 
 ### Publishing a Release
+
 **Note:** You need admin privileges to publish a release. If you don't have them, ask someone who does to do the release for you.
 
 Setup:
+
 - run `aws sso login`
 - run `./scripts/brew-install.sh`
 - ensure you're on the main branch with the latest code
@@ -138,4 +146,3 @@ This will create three files in the `dist/sdk/js` folder:
 ```
 
 Upload them all to S3. Ensure that their access controls allow public access.
-

dev-apps/js-cloud-server/cloudflare-worker/project.json

@@ -11,6 +11,7 @@
                 "outputPath": "dist/dev-apps/js-cloud-server/cloudflare-worker",
                 "main": "dev-apps/js-cloud-server/cloudflare-worker/src/index.ts",
                 "tsConfig": "dev-apps/js-cloud-server/cloudflare-worker/tsconfig.json",
+                "webpackConfig": "dev-apps/js-cloud-server/cloudflare-worker/webpack.config.js",
                 "compiler": "tsc",
                 "target": "node"
             }
@@ -31,7 +32,7 @@
             "dependsOn": ["upload-sourcemaps"]
         },
         "lint": {
-            "executor": "@nx/linter:eslint",
+            "executor": "@nx/eslint:lint",
             "outputs": ["{options.outputFile}"],
             "options": {
                 "lintFilePatterns": [

dev-apps/js-cloud-server/cloudflare-worker/webpack.config.js

@@ -0,0 +1,27 @@
+const { composePlugins, withNx } = require('@nx/webpack')
+
+module.exports = composePlugins(withNx(), (config, { options }) => {
+    config.node = {
+        __dirname: true,
+    }
+    if (!config.resolve) {
+        config.resolve = {}
+    }
+    // Disable browser field resolution for node targets
+    config.resolve.mainFields = ['main', 'module']
+    config.resolve.conditionNames = ['node', 'require', 'import']
+    // Configure externals - webpack externals function
+    if (options.external && Array.isArray(options.external)) {
+        config.externals = config.externals || []
+        const externalArray = Array.isArray(config.externals)
+            ? config.externals
+            : [config.externals]
+        config.externals = [
+            ...externalArray,
+            ...options.external.map((pkg) => ({
+                [pkg]: `commonjs ${pkg}`,
+            })),
+        ]
+    }
+    return config
+})

dev-apps/js/project.json

@@ -22,7 +22,8 @@
                     "dev-apps/js/src/assets"
                 ],
                 "styles": ["dev-apps/js/src/styles.css"],
-                "scripts": []
+                "scripts": [],
+                "webpackConfig": "dev-apps/js/webpack.config.js"
             },
             "configurations": {
                 "production": {
@@ -63,7 +64,7 @@
             "defaultConfiguration": "development"
         },
         "lint": {
-            "executor": "@nx/linter:eslint",
+            "executor": "@nx/eslint:lint",
             "outputs": ["{options.outputFile}"],
             "options": {
                 "lintFilePatterns": ["dev-apps/js/**/*.ts"]

dev-apps/js/webpack.config.js

@@ -0,0 +1,3 @@
+const { composePlugins, withNx, withWeb } = require('@nx/webpack')
+
+module.exports = composePlugins(withNx(), withWeb(), (config) => config)