feat: upgrade NX and migrate builds to esbuild by jonathannorris · Pull Request #1185 · DevCycleHQ/js-sdks

jonathannorris · 2025-11-25T22:06:05Z

Summary

Upgrade NX from 16.10.0 to 22.1.1
Migrate all @nx/js:tsc builds to @nx/esbuild:esbuild
Update webpack configs and project configurations for NX 22 compatibility
Update E2E workflow to pre-build shared libraries
Removed Next.js dev-apps/next, the e2e/nextjs apps work for testing + e2e tests

Why
NX 22 removed the experimental external option from @nx/js:tsc that was used to bundle internal workspace packages. These packages are not published to npm and must be bundled into the SDK dist. Additionally, NX 22 introduced breaking changes requiring updates to webpack configs, Jest configs, and project.json files.

Changes

Build system: Migrated all SDKs/libs from tsc to esbuild for faster builds
nodejs, js-cloud-server: Now use esbuild to bundle internal dependencies
Webpack configs: Updated dev-apps (js, openfeature-web, cloudflare-worker, nodejs-local, openfeature-nodejs) and e2e tests for NX 22 compatibility
Project configs: Updated all project.json files with new executor configurations
Jest configs: Updated to use NX 22 patterns across all packages
E2E workflow: Added shared library build step before running affected E2E tests
Fixes: Updated e2e test ports, fixed type exports, resolved rollup build issues for react-native-expo, preserved Next.js 'use client' directives

Testing

All SDK tests pass (nodejs: 126, js-cloud-server: 71, bucketing: 222)
Verified against local example apps
E2E tests updated and verified

vercel · 2025-11-25T22:06:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
js-sdks-web-elements	Ready	Preview, Comment	Jan 9, 2026 4:28pm
js-sdks-with-provider	Ready	Preview, Comment	Jan 9, 2026 4:28pm

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
js-sdks-next-js-page-router	Ignored		Jan 9, 2026 4:28pm

Copilot

Pull request overview

Copilot reviewed 92 out of 102 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…th their configurations and assets

…ges-router entries

Copilot

Pull request overview

Copilot reviewed 118 out of 135 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

sdk/nextjs/src/common/actions/setDebugUser.ts:1

Using bracket notation for environment variables (process.env['NODE_ENV']) is unnecessary. The dot notation process.env.NODE_ENV is more idiomatic and equally safe in TypeScript/Node.js environments.
sdk/nextjs/src/common/actions/clearDebugUser.ts:1
Using bracket notation for environment variables (process.env['NODE_ENV']) is unnecessary. The dot notation process.env.NODE_ENV is more idiomatic and equally safe in TypeScript/Node.js environments.
e2e/nextjs/app-router/tests/app-router.spec.ts:1
The timeout was increased from 10000 to 30000ms. Consider adding a comment explaining why such a long timeout is necessary for this navigation test, as this could mask performance issues.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…output

Copilot

Pull request overview

Copilot reviewed 120 out of 137 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JamieSinn · 2026-01-02T18:52:27Z

worth copying these changes elsewhere?

its basically just formatting, so probably not

kaushalkapasi · 2026-01-06T19:06:33Z

    PublicEnvironment,
+    PublicFeature,
    PublicProject,
+    PublicTarget,


unused import changes? or were these missing?

Copilot

Pull request overview

Copilot reviewed 120 out of 137 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T16:31:36Z

+    // Configure externals - use array format which is simpler and more reliable
+    if (options.external && Array.isArray(options.external)) {
+        // Convert to object format for webpack externals
+        const externalsObj = {}
+        options.external.forEach((pkg) => {
+            externalsObj[pkg] = `commonjs ${pkg}`
+        })
+        const originalExternals = config.externals
+        if (originalExternals) {
+            if (Array.isArray(originalExternals)) {
+                config.externals = [...originalExternals, externalsObj]
+            } else if (typeof originalExternals === 'object') {
+                config.externals = { ...originalExternals, ...externalsObj }
+            } else {
+                config.externals = [originalExternals, externalsObj]
+            }
+        } else {
+            config.externals = externalsObj
+        }
+    }


The externals configuration logic is complex and handles multiple array/object cases. This same pattern appears in multiple webpack configs. Consider extracting this into a shared utility function to reduce code duplication and improve maintainability across dev-apps/nodejs-local, dev-apps/openfeature-nodejs, and dev-apps/nodejs-cloud webpack configs.

Copilot · 2026-01-09T16:31:37Z

                "external": [
-                    "shared-types",
-                    "shared-bucketing-as",
-                    "shared-bucketing-test-data",
-                    "js-cloud-server-sdk",
-                    "js"
-                ]
-            },
-            "dependsOn": [
-                {
-                    "target": "build",
-                    "dependencies": true
+                    "@devcycle/types",
+                    "@devcycle/bucketing-assembly-script",
+                    "@devcycle/js-cloud-server-sdk",
+                    "@devcycle/js-client-sdk",
+                    "@openfeature/*",
+                    "cross-fetch",
+                    "eventsource",
+                    "fetch-retry"


The SDK build has been migrated to esbuild with bundle: true and a comprehensive list of external packages. However, cross-fetch, eventsource, and fetch-retry are marked as external, which means they will be runtime dependencies. Verify that these packages are properly included in the package.json dependencies and not just devDependencies, as the bundled SDK will require them at runtime.

Copilot · 2026-01-09T16:31:37Z

        "react": ">=16.8.0"
    },
-    "types": "./index.cjs.d.ts"
+    "types": "./index.d.ts"


The types field has been changed from "./index.cjs.d.ts" to "./index.d.ts". Verify that the build output actually generates index.d.ts files at the package root, and not index.cjs.d.ts files. If esbuild generates the types with a different naming convention, this change may break TypeScript resolution for package consumers.

Copilot · 2026-01-09T16:31:37Z

        "@devcycle/nodejs-server-sdk": "1.55.6"
    },
-    "main": "src/index.js",
+    "main": "index.js",


The main field has been changed from "src/index.js" to "index.js". This indicates that the build output structure has changed. Verify that the esbuild configuration actually outputs files to the package root (index.js) rather than maintaining the src/ directory structure. If the build outputs to a different location, package consumers will not be able to import this package.

Copilot · 2026-01-09T16:31:38Z

-    // Increase timeout for navigation in CI
    await expect(page.getByText('Navigated Server Component')).toBeVisible({
-        timeout: 10000,
+        timeout: 30000, // Increased timeout for CI environment variability


The timeout has been increased from 10000ms to 30000ms with a comment stating "Increased timeout for CI environment variability". While this may address flaky tests in CI, such a large timeout increase (3x) could mask underlying performance issues or race conditions. Consider investigating the root cause of the timeout issues rather than simply increasing the timeout value.

Copilot · 2026-01-09T16:31:38Z

    "packageManager": "yarn@4.9.2",
    "scripts": {
-        "lint": "nx run-many --parallel --target lint --all",
+        "lint": "nx run-many --parallel --target check-types --all && nx run-many --parallel --target lint --all",


The lint script now runs check-types before lint. This means type checking will run twice - once explicitly via check-types and again as part of the lint process if ESLint has TypeScript rules enabled. This could slow down the CI pipeline. Consider whether both are necessary or if type checking should only be done once.

Copilot · 2026-01-09T16:31:39Z

+{
+    "extends": "./tsconfig.lib.json",
+    "compilerOptions": {
+        "paths": {}
+    }
+}


A new tsconfig.build.json file has been added that extends tsconfig.lib.json and clears the paths. However, the project.json now references this new file instead of tsconfig.lib.json. Verify that this doesn't break any workspace path aliases that might be needed during the build process. The empty paths object may prevent proper resolution of internal workspace dependencies.

Copilot · 2026-01-09T16:31:39Z

+    // Fix __dirname replacement for bucketing-assembly-script to use absolute path
+    // This ensures path.resolve(__dirname) works correctly
+    if (!config.plugins) {
+        config.plugins = []
+    }
+    const webpack = require('webpack')
+    config.plugins.push(
+        new webpack.DefinePlugin({
+            __dirname: JSON.stringify(
+                path.resolve(
+                    __dirname,
+                    '../../lib/shared/bucketing-assembly-script',
+                ),
+            ),
+        }),
+    )


The manual path resolution using __dirname and path.resolve may be fragile. The webpack DefinePlugin is being used to override __dirname globally, which could have unintended side effects on other parts of the bundled code. A more targeted approach, such as using webpack's resolve.alias for the specific bucketing-assembly-script module, would be safer.

vercel Bot had a problem deploying to Preview – js-sdks-web-elements November 25, 2025 22:07 Failure

vercel Bot deployed to Preview – js-sdks-with-provider November 25, 2025 22:07 View deployment

vercel Bot had a problem deploying to Preview – js-sdks-web-elements November 26, 2025 15:00 Failure

vercel Bot deployed to Preview – js-sdks-with-provider November 26, 2025 15:01 View deployment

vercel Bot deployed to Preview – js-sdks-with-provider November 26, 2025 15:16 View deployment

vercel Bot had a problem deploying to Preview – js-sdks-web-elements November 26, 2025 15:16 Failure

vercel Bot deployed to Preview – js-sdks-with-provider November 26, 2025 15:23 View deployment

vercel Bot had a problem deploying to Preview – js-sdks-web-elements November 26, 2025 15:23 Failure

vercel Bot deployed to Preview – js-sdks-with-provider November 26, 2025 15:58 View deployment

vercel Bot had a problem deploying to Preview – js-sdks-web-elements November 26, 2025 15:59 Failure

vercel Bot had a problem deploying to Preview – js-sdks-web-elements November 26, 2025 18:37 Failure

vercel Bot deployed to Preview – js-sdks-with-provider November 26, 2025 18:37 View deployment

vercel Bot deployed to Preview – js-sdks-with-provider November 26, 2025 18:42 View deployment

vercel Bot had a problem deploying to Preview – js-sdks-web-elements November 26, 2025 18:42 Failure

jonathannorris force-pushed the feat-nx-migration branch from 88f354b to 3cf8690 Compare December 5, 2025 20:17

vercel Bot had a problem deploying to Preview – js-sdks-web-elements December 5, 2025 20:18 Failure

vercel Bot deployed to Preview – js-sdks-with-provider December 5, 2025 20:18 View deployment

jonathannorris force-pushed the feat-nx-migration branch from 3cf8690 to ef9ef69 Compare December 11, 2025 20:53

vercel Bot deployed to Preview – js-sdks-with-provider December 11, 2025 20:55 View deployment

vercel Bot had a problem deploying to Preview – js-sdks-web-elements December 11, 2025 20:55 Failure

jonathannorris added 6 commits December 15, 2025 09:56

feat: upgrade nx from 16.10.0 to 22.1.1

dc2602d

feat: migrate all tsc builds to esbuild

abe7c90

fix: ignore tmp directory in bucketing-assembly-script eslint config

b941033

chore: run prettier

0ca4f56

fix: update e2e configs for NX 22 compatibility

1e3cd14

fix: use tsc for nextjs SDK to preserve 'use client' directives

b04f598

vercel Bot had a problem deploying to Preview – js-sdks-with-provider December 15, 2025 14:56 Failure

vercel Bot had a problem deploying to Preview – js-sdks-web-elements December 15, 2025 14:57 Failure

chore: update e2e yarn.lock files

cc4d0f8

vercel Bot deployed to Preview – js-sdks-with-provider December 19, 2025 20:25 View deployment

fix: add fallback for undefined projects in playwright configs

dbb999e

vercel Bot deployed to Preview – js-sdks-web-elements December 19, 2025 21:24 View deployment

vercel Bot deployed to Preview – js-sdks-with-provider December 19, 2025 21:24 View deployment

fix: format playwright configs to comply with max-len

92b227d

Copilot AI review requested due to automatic review settings December 19, 2025 21:27

Copilot started reviewing on behalf of jonathannorris December 19, 2025 21:27 View session

vercel Bot deployed to Preview – js-sdks-web-elements December 19, 2025 21:28 View deployment

vercel Bot deployed to Preview – js-sdks-with-provider December 19, 2025 21:28 View deployment

Copilot AI reviewed Dec 19, 2025

View reviewed changes

jonathannorris added 9 commits December 19, 2025 16:30

chore: apply prettier formatting to playwright configs

bbaccf6

chore: add worktrees.json for cursor worktree setup

3a868d1

chore: create worktrees.json for setting up cursor worktree

6d15b3f

fix: resolve WASM path and webpack config for nodejs-local dev-app

1daeddc

fix: resolve WASM path and webpack config for openfeature-nodejs dev-app

ca8f6f9

chore: add trailing newline to js webpack config

04f388c

chore: remove nextjs app-router and pages-router directories along wi…

4c07218

…th their configurations and assets

chore: clean up yarn.lock by removing unused nextjs app-router and pa…

3ec1c58

…ges-router entries

chore: simplify JSON formatting and clean up webpack configuration files

5a4419a

Copilot AI reviewed Dec 23, 2025

View reviewed changes

jonathannorris added 2 commits December 23, 2025 14:06

chore: update webpack configuration to use Nx plugin composition

0e1df07

fix: correct package.json main fields for nestjs SDKs to match build …

ea64662

…output

Copilot AI reviewed Dec 23, 2025

View reviewed changes

Comment thread e2e/nextjs/pages-router/playwright.config.ts

Comment thread e2e/nextjs/app-router/playwright.config.ts

Comment thread e2e/js/js-esm/playwright.config.ts

Comment thread e2e/js/js-cdn/playwright.config.ts

jonathannorris added 2 commits December 31, 2025 15:09

chore: use dot notation for process.env and add timeout comment

e8a8fa0

fix: lint errors and simplify webpack config

331f493

JamieSinn reviewed Jan 2, 2026

View reviewed changes

JamieSinn approved these changes Jan 2, 2026

View reviewed changes

kaushalkapasi reviewed Jan 6, 2026

View reviewed changes

fix: reduce CDN bundle size by using tsc compiler

947e664

Copilot AI reviewed Jan 9, 2026

View reviewed changes

Uh oh!

Conversation

jonathannorris commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JamieSinn Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

jonathannorris Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

kaushalkapasi Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathannorris commented Nov 25, 2025 •

edited

Loading

vercel Bot commented Nov 25, 2025 •

edited

Loading