Skip to content

🚧 [PANA-6282] Add USE_INCREMENTAL_CHANGE_RECORDS feature flag#4284

Merged
sethfowler-datadog merged 2 commits intomainfrom
seth.fowler/PANA-6282-add-USE_INCREMENTAL_CHANGE_RECORDS-feature-flag
Mar 6, 2026
Merged

🚧 [PANA-6282] Add USE_INCREMENTAL_CHANGE_RECORDS feature flag#4284
sethfowler-datadog merged 2 commits intomainfrom
seth.fowler/PANA-6282-add-USE_INCREMENTAL_CHANGE_RECORDS-feature-flag

Conversation

@sethfowler-datadog
Copy link
Contributor

Motivation

I'm preparing to push the PR that will add incremental snapshot support for Change records. To make testing easier, it'll be easier to have incremental snapshot support on a separate feature flag.

Changes

This PR adds a second feature flag, USE_INCREMENTAL_CHANGE_RECORDS, to control incremental snapshot support.

When this feature flag is on, we behave as if USE_CHANGE_RECORDS is also on. This is just to ensure that nobody accidentally runs in a weird, untested configuration where the full snapshots use the old format but the incremental snapshots use the new one; while this should work, I don't want to have to test it. 🙂

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@sethfowler-datadog sethfowler-datadog requested review from a team as code owners March 5, 2026 16:45
@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Mar 5, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 75.00%
Overall Coverage: 76.72% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d097957 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Base automatically changed from seth.fowler/PANA-6258-more-robustly-prevent-serialization-of-style-children to main March 6, 2026 10:29
@sethfowler-datadog sethfowler-datadog force-pushed the seth.fowler/PANA-6282-add-USE_INCREMENTAL_CHANGE_RECORDS-feature-flag branch from bf48657 to d097957 Compare March 6, 2026 12:00
@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Mar 6, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 174.37 KiB 174.43 KiB +66 B +0.04%
Rum Profiler 6.16 KiB 6.16 KiB 0 B 0.00%
Rum Recorder 25.14 KiB 25.24 KiB +102 B +0.40%
Logs 56.78 KiB 56.84 KiB +66 B +0.11%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 130.05 KiB 130.11 KiB +66 B +0.05%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.004 0.0041 +2.50%
RUM - add action 0.0123 0.0123 0.00%
RUM - add error 0.0148 0.0119 -19.59%
RUM - add timing 0.0031 0.0026 -16.13%
RUM - start view 0.0123 0.0112 -8.94%
RUM - start/stop session replay recording 0.0008 0.0007 -12.50%
Logs - log message 0.0139 0.0136 -2.16%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.77 KiB 26.62 KiB -154 B
RUM - add action 50.50 KiB 50.50 KiB -4 B
RUM - add timing 25.75 KiB 26.92 KiB +1.17 KiB
RUM - add error 55.64 KiB 55.40 KiB -241 B
RUM - start/stop session replay recording 25.25 KiB 26.31 KiB +1.06 KiB
RUM - start view 448.46 KiB 451.21 KiB +2.75 KiB
Logs - log message 43.63 KiB 45.16 KiB +1.53 KiB

🔗 RealWorld

@sethfowler-datadog sethfowler-datadog merged commit 305b92d into main Mar 6, 2026
21 checks passed
@sethfowler-datadog sethfowler-datadog deleted the seth.fowler/PANA-6282-add-USE_INCREMENTAL_CHANGE_RECORDS-feature-flag branch March 6, 2026 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants