🚧 [PANA-6282] Add USE_INCREMENTAL_CHANGE_RECORDS feature flag

Author: sethfowler-datadog

packages/core/src/tools/experimentalFeatures.ts

@@ -21,6 +21,7 @@ export enum ExperimentalFeature {
   START_STOP_ACTION = 'start_stop_action',
   START_STOP_RESOURCE = 'start_stop_resource',
   USE_CHANGE_RECORDS = 'use_change_records',
+  USE_INCREMENTAL_CHANGE_RECORDS = 'use_incremental_change_records',
   LCP_SUBPARTS = 'lcp_subparts',
   INP_SUBPARTS = 'inp_subparts',
 }

packages/rum/src/domain/record/startFullSnapshots.ts

@@ -83,7 +83,8 @@ export function takeFullSnapshot(
 }
 
 function defaultSerializeFullSnapshotCallback(): SerializeFullSnapshotCallback {
-  return isExperimentalFeatureEnabled(ExperimentalFeature.USE_CHANGE_RECORDS)
+  return isExperimentalFeatureEnabled(ExperimentalFeature.USE_CHANGE_RECORDS) ||
+    isExperimentalFeatureEnabled(ExperimentalFeature.USE_INCREMENTAL_CHANGE_RECORDS)
     ? serializeFullSnapshotAsChange
     : serializeFullSnapshot
 }

packages/rum/src/domain/segmentCollection/startSegmentTelemetry.spec.ts

@@ -49,13 +49,16 @@ describe('segmentTelemetry', () => {
     registerCleanupTask(stopSegmentTelemetry)
   }
 
-  for (const enableChangeRecords of [true, false] as const) {
-    const titlePrefix = enableChangeRecords ? 'with change records' : 'without change records'
-
-    it(`${titlePrefix}, should collect segment telemetry for all full snapshots`, async () => {
-      if (enableChangeRecords) {
-        addExperimentalFeatures([ExperimentalFeature.USE_CHANGE_RECORDS])
+  for (const changeRecordFeatureFlag of [
+    undefined,
+    ExperimentalFeature.USE_CHANGE_RECORDS,
+    ExperimentalFeature.USE_INCREMENTAL_CHANGE_RECORDS,
+  ] as const) {
+    it(`with ${changeRecordFeatureFlag || 'v1_records'}, should collect segment telemetry for all full snapshots`, async () => {
+      if (changeRecordFeatureFlag) {
+        addExperimentalFeatures([changeRecordFeatureFlag])
       }
+
       setupSegmentTelemetryCollection()
 
       for (const result of ['failure', 'queue-full', 'success'] as const) {
@@ -73,8 +76,9 @@ describe('segmentTelemetry', () => {
                 sum: 500,
               },
               encoding: {
-                fullSnapshot: enableChangeRecords ? 'change' : 'v1',
-                incrementalSnapshot: 'v1',
+                fullSnapshot: changeRecordFeatureFlag ? 'change' : 'v1',
+                incrementalSnapshot:
+                  changeRecordFeatureFlag === ExperimentalFeature.USE_INCREMENTAL_CHANGE_RECORDS ? 'change' : 'v1',
               },
               isFullSnapshot: true,
               ongoingRequests: {

packages/rum/src/domain/segmentCollection/startSegmentTelemetry.ts

@@ -73,8 +73,14 @@ function createSegmentMetrics(
       sum: payload.cssText.sum,
     },
     encoding: {
-      fullSnapshot: isExperimentalFeatureEnabled(ExperimentalFeature.USE_CHANGE_RECORDS) ? 'change' : 'v1',
-      incrementalSnapshot: 'v1',
+      fullSnapshot:
+        isExperimentalFeatureEnabled(ExperimentalFeature.USE_CHANGE_RECORDS) ||
+        isExperimentalFeatureEnabled(ExperimentalFeature.USE_INCREMENTAL_CHANGE_RECORDS)
+          ? 'change'
+          : 'v1',
+      incrementalSnapshot: isExperimentalFeatureEnabled(ExperimentalFeature.USE_INCREMENTAL_CHANGE_RECORDS)
+        ? 'change'
+        : 'v1',
     },
     isFullSnapshot: payload.isFullSnapshot,
     ongoingRequests: {