generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 372
London | 26-ITP-Jan | Oussama Mouggal | Sprint 1| Form controls #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oussama-Mouggal
wants to merge
16
commits into
CodeYourFuture:main
Choose a base branch
from
Oussama-Mouggal:Form-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−52
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a8f1b77
I add titles
Oussama-Mouggal 58e9b35
I added the definitions
Oussama-Mouggal 731c575
I added pictures using urls
Oussama-Mouggal 0be1fa5
I fixed the footer using css
Oussama-Mouggal 8a68c7c
add alt description
Oussama-Mouggal 485d24c
i added name and email labels
Oussama-Mouggal 9623540
I added black colour radio button
Oussama-Mouggal 9e1df81
added blue colour label and button
Oussama-Mouggal a6cc42d
added red colour choice
Oussama-Mouggal 8d0c5e9
added sizes choices in form of selected options
Oussama-Mouggal c4e28e9
added a submit button to validate name and email
Oussama-Mouggal 2edc649
fix: label to better redability
Oussama-Mouggal ed7b38b
cleaning code
Oussama-Mouggal 89b79e0
Update Form-Controls/index.html
Oussama-Mouggal 7a8807b
Update Form-Controls/index.html
Oussama-Mouggal 0e5a82b
Update Form-Controls/index.html
Oussama-Mouggal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,15 +13,54 @@ <h1>Product Pick</h1> | |
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name" required | ||
| minlength="2" pattern="^[A-Za-z ]{2,}$" | ||
| title="Name must be at least 2 letters and contain only letters" | ||
| /> | ||
| <br /><br /> | ||
| <label for="email">Email:</label> | ||
| <input type="email" id="email" name="email" placeholder="[email protected]" required /> | ||
| <br /><br /> | ||
| <button type="submit">Submit</button> | ||
| <br /> | ||
| <br /> | ||
| <fieldset> | ||
| <legend>Please select a color:</legend> | ||
| <input type="radio" id="black" name="color" value="black" /> | ||
| <label for="black">black</label> | ||
| <br /> | ||
| <br /> | ||
| <input type="radio" id="blue" name="color" value="blue" /> | ||
| <label for="blue">blue</label> | ||
| <br /> | ||
| <br /> | ||
| <input type="radio" id="red" name="color" value="red" /> | ||
| <label for="red">red</label> | ||
| <br /> | ||
| <br /> | ||
| </fieldset> | ||
| <label for="size">Please select a size:</label> | ||
| <select id="size" name="size" required> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| <br /><br /> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| What is the customer's name? I must collect this data, and validate it. | ||
| But what is a valid name? I must decide something. | ||
| What is the customer's email? I must make sure the email is valid. Email addresses have a consistent pattern. | ||
| What colour should this t-shirt be? I must give 3 options. How will I make sure they don't pick other colours? | ||
| What size does the customer want? I must give the following 6 options: XS, S, M, L, XL, XXL--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h2>By Oussama Mouggal sponsored by Codeyourfuture </h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,4 +30,4 @@ <h2>Title</h2> | |
| </p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,4 +86,4 @@ article { | |
| > img { | ||
| grid-column: span 3; | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The submit button is placed before the color and size selection fields. This creates a confusing user experience as users would typically expect the submit button to appear after all form fields. The submit button should be moved to the end of the form, after all input fields have been collected.