London | 26-ITP-Jan | Oussama Mouggal | Sprint 1| Form controls #969
Conversation
Oussama-Mouggal
added
the
Needs Review
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR implements a product order form for a t-shirt selection system as part of a Code Your Future Sprint 1 assignment. The student has created an HTML-only form with name and email validation, color selection via radio buttons, and size selection via a dropdown menu.
Changes:
- Implemented form controls with name validation (minimum 2 characters, letters only)
- Added email input with placeholder and validation
- Created radio button group for color selection (black, blue, red)
- Added dropdown select for size options (XS through XXL)
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Form-Controls/index.html | Added complete form implementation with input validation, radio buttons for color selection, and dropdown for size selection |
| index.html | Root navigation file deleted (appears unintentional) |
| Wireframe/style.css | Minor newline added at end of file |
| Wireframe/index.html | Minor newline added at end of file |
Comments suppressed due to low confidence (1)
index.html:1
- The entire root index.html file has been deleted. This file appears to be a navigation page that lists the coursework projects (Wireframe and Form Controls). Deleting this file breaks the ability to navigate between projects and should be restored. This deletion appears unintentional and unrelated to the Form Controls assignment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <label for="email">Email:</label> | ||
| <input type="email" id="email" name="email"placeholder="[email protected]"required /> | ||
| <br /><br /> | ||
| <button type="submit">Submit</button> |
There was a problem hiding this comment.
The submit button is placed before the color and size selection fields. This creates a confusing user experience as users would typically expect the submit button to appear after all form fields. The submit button should be moved to the end of the form, after all input fields have been collected.
Form-Controls/index.html
Outdated
| <input type="radio" id="black" name="color" value="black"/> | ||
| <label for="black">black</label> | ||
| <br /> | ||
| <br /> | ||
| <input type="radio" id="blue" name="color" value="blue"/> | ||
| <label for="blue">blue</label> | ||
| <br /> | ||
| <br /> | ||
| <input type="radio" id="red" name="color" value="red"/> | ||
| <label for="red">red</label> |
There was a problem hiding this comment.
The color radio buttons are not marked as required, even though the assignment specifies "All fields are required." At least one radio button in the group should have the required attribute to ensure users select a color before submitting.
Oussama-Mouggal
changed the title
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
1 participant
Self checklist
Changelist
Used html only to create forms with good accebility