Character creator ImGui migration

[ShnitzelX2]

Summary

Interface "character creator ImGui migration"

Purpose of change

Update character creator UI to ImGui, and improve maintainability by not having seven different UI layouts.

This should be functional, so please build and test it for yourself. Feedback is very welcome.

Describe the solution

Minor non-infrastructure changes to the UI layout:

• Basic character information appears on the "top bar" and can be changed at any time.
• All tabs (excluding the "SUMMARY" tab) display with a uilist on the left and tab information on the right.
• Magic numbers were replaced with constants, see character.h, game_constants.h.
• Sub-tab support for traits and skills.

Some changes to uilist were required. uilist::query has been modified such that uilist can be utilized as a UI component along with being a standalone prompt.

Describe alternatives you've considered

• uilist does not have sorting support, but it does have filter support. Thus, the tab lists no longer support sorting, though whether it's useful currently is up for debate.
• drawing uilist at a fixed size instead of just to fit the max entry size
  - uilist::allow_disabled = true still skips selection of disabled entries, I would use it for traits if it worked it works, my bad

Testing

Checklist:

Basics:

• Create a "Custom Character" and advance to game with that character
• "Preset Character" ..
• "Random Character" ..
• "Play Now!" still works
• Exit to main menu
• Exiting and re-entering character creator resets properly
• Aftershock random character
• Magiclysm random character
• MA mod custom character (a mod with 1 scenario)

Actions (all keybinds, mouse):

• (+, +) "NEXT_TAB" / "PREV_TAB"
• (+, N/A) "QUIT"
• • "HELP_KEYBINDINGS"
• (+, +) "SAVE_TEMPLATE"
• (+, +) "RANDOMIZE_CHAR_NAME"
• (+, +) "RANDOMIZE_CHAR_DESCRIPTION"
• (+, +) "REROLL_CHARACTER"
• (+, +) "REROLL_CHARACTER_WITH_SCENARIO"
• (+, +) "CHANGE_GENDER"
• (+, +) "CHANGE_OUTFIT"
• (+, +) "CHANGE_NAME"
• (+, +) "CHANGE_AGE"
• (+, +) "CHANGE_HEIGHT"
• (+, +) "CHANGE_BLOOD_TYPE"
• (+, +) "CHANGE_START_OF_CATACLYSM"
• (+, +) "CHANGE_START_OF_GAME"
• (+, +) "RESET_CALENDAR"
• (+, +) "SCROLL_INFOBOX_UP" / "SCROLL_INFOBOX_DOWN"
• (+, +) "CHOOSE_CITY"
• (+, +) "CHOOSE_LOCATION"

Screenshots

filter: "challenge"

Additional context

Remaining tasks:

• no keybind to scroll through right-side details
• professions inventory recalculates per-draw
• skills uilist does not draw at correct width
  - [ ] SUMMARY tab input lag (low priority for now)
• handle commented block in past_games_info.cpp
• CI
• testing and any other cleanup

uilist and other ImGui bugs:

• filter footer_text gets cut off at bottom of uilist
• width sometimes cuts off a character for longest entry
• existing uilist double-selection bug
• number input popups don't resize to prompt text properly

[github-actions]

Auto-requesting reviews from non-collaborators: @Qrox

[RenechCDDA]

I haven't reviewed this, but I did read your summary.

Is there a reason for using a uilist over imgui's native listbox? It sounds like you had to modify uilist to work much like listbox, which seems redundant.

[ShnitzelX2]

Is there a reason for using a uilist over imgui's native listbox? It sounds like you had to modify uilist to work much like listbox, which seems redundant.

Yes: uilist is an existing list structure with lots of useful built-in features already implemented in ImGui. It seemed redundant to me not to just modify it to be more flexible, and my main goal was to not make yet another list implementation.

[ShnitzelX2]

Recent commits include changing the top bar and summary to have buttons functioning as clickable alternatives to existing keybinds:

[GuardianDll]

let's goooo

[Inglonias]

Congratulations!